Skip to content

refactor: remove assert statement from non-test files #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepsource-autofix wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: remove assert statement from non-test files #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/requests/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@

def check_compatibility(urllib3_version, chardet_version, charset_normalizer_version):
urllib3_version = urllib3_version.split(".")
assert urllib3_version != ["dev"] # Verify urllib3 isn't installed from git.
if urllib3_version == ["dev"]: # Verify urllib3 isn't installed from git.
raise AssertionError()

# Sometimes, urllib3 only reports its version as 16.1.
if len(urllib3_version) == 2:
Expand All @@ -67,21 +68,25 @@ def check_compatibility(urllib3_version, chardet_version, charset_normalizer_ver
major, minor, patch = urllib3_version # noqa: F811
major, minor, patch = int(major), int(minor), int(patch)
# urllib3 >= 1.21.1
assert major >= 1
if major < 1:
raise AssertionError()
if major == 1:
assert minor >= 21
if minor < 21:
raise AssertionError()

# Check charset_normalizer for compatibility.
if chardet_version:
major, minor, patch = chardet_version.split(".")[:3]
major, minor, patch = int(major), int(minor), int(patch)
# chardet_version >= 3.0.2, < 6.0.0
assert (3, 0, 2) <= (major, minor, patch) < (6, 0, 0)
if not ((3, 0, 2) <= (major, minor, patch) < (6, 0, 0)):
raise AssertionError()
elif charset_normalizer_version:
major, minor, patch = charset_normalizer_version.split(".")[:3]
major, minor, patch = int(major), int(minor), int(patch)
# charset_normalizer >= 2.0.0 < 4.0.0
assert (2, 0, 0) <= (major, minor, patch) < (4, 0, 0)
if not ((2, 0, 0) <= (major, minor, patch) < (4, 0, 0)):
raise AssertionError()
else:
warnings.warn(
"Unable to find acceptable character detection dependency "
Expand Down