refactor: simplify complex methods to reduce cyclomatic complexity - #10
Open
deepsource-dev-autofix[bot] wants to merge 1 commit into
Open
refactor: simplify complex methods to reduce cyclomatic complexity#10deepsource-dev-autofix[bot] wants to merge 1 commit into
deepsource-dev-autofix[bot] wants to merge 1 commit into
Conversation
This PR refactors several large methods in the resolver to break down deeply nested logic into smaller helper functions, reducing cyclomatic complexity and improving readability and maintainability. - Function with cyclomatic complexity higher than threshold: The original `complete_package`, `get_locked`, and `debug` methods contained multiple nested branches and repeated patterns, making them hard to follow and maintain. We extracted the package resolution logic into an inner `_fetch` helper and introduced dedicated formatting functions (`_format_fact`, `_format_selecting`, `_format_derived`, and `_format_conflict`) for the debug output. By consolidating shared behavior and flattening conditional structures, the overall complexity of these methods has been significantly reduced. > This Autofix was generated by AI. Please review the change before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors several large methods in the resolver to break down deeply nested logic into smaller helper functions, reducing cyclomatic complexity and improving readability and maintainability.
complete_package,get_locked, anddebugmethods contained multiple nested branches and repeated patterns, making them hard to follow and maintain. We extracted the package resolution logic into an inner_fetchhelper and introduced dedicated formatting functions (_format_fact,_format_selecting,_format_derived, and_format_conflict) for the debug output. By consolidating shared behavior and flattening conditional structures, the overall complexity of these methods has been significantly reduced.