Skip to content

refactor: secure database queries against parameter tampering #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepsource-dev-autofix wants to merge 1 commit into
base: v1.18.1-base
Choose a base branch
from
Open

refactor: secure database queries against parameter tampering #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions include/staff/templates.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,28 @@
$qs += array('sort' => $_REQUEST['sort'], 'order' => $_REQUEST['order']);
$pageNav->setURL('templates.php', $qs);
$qstr .= '&order='.($order=='DESC' ? 'ASC' : 'DESC');
$query="$sql GROUP BY tpl.tpl_id ORDER BY $order_by LIMIT ".$pageNav->getStart().",".$pageNav->getLimit();
$res=db_query($query);
if($res && ($num=db_num_rows($res)))

// Prepare secure query using mysqli prepared statements
$mysqli = new mysqli(DBHOST, DBUSER, DBPASS, DBNAME);
if ($mysqli->connect_error) {
error_log('Database Connection Error: ' . $mysqli->connect_error);
$res = null;
$num = 0;
} else {
$query = $sql . ' GROUP BY tpl.tpl_id ORDER BY ' . $order_by . ' LIMIT ?, ?';
$stmt = $mysqli->prepare($query);
$start = (int)$pageNav->getStart();
$limit = (int)$pageNav->getLimit();
$stmt->bind_param('ii', $start, $limit);
$stmt->execute();
$res = $stmt->get_result();
$num = $res->num_rows;
}
if ($num) {
$showing=$pageNav->showing().' '._N('template', 'templates', $num);
else
} else {
$showing=__('No templates found!');
}

?>
<form action="templates.php" method="POST" name="tpls">
Expand Down Expand Up @@ -98,15 +114,15 @@
<?php
$total=0;
$ids=($errors && is_array($_POST['ids']))?$_POST['ids']:null;
if($res && db_num_rows($res)):
if($res && $num):
$defaultTplId=$cfg->getDefaultTemplateId();
while ($row = db_fetch_array($res)) {
while ($row = $res->fetch_assoc()) {
$inuse=($row['depts'] || $row['tpl_id']==$defaultTplId);
$sel=false;
if($ids && in_array($row['tpl_id'],$ids))
$sel=true;

$default=($defaultTplId==$row['tpl_id'])?'<small class="faded">('.__('System Default').')</small>':'';
$default=($defaultTplId==$row['tpl_id'])?'<small class="faded">('.__('System Default').')</small>':' ';
?>
<tr id="<?php echo $row['tpl_id']; ?>">
<td align="center">
Expand Down