refactor: escape import output to prevent stored xss - #2
Open
deepsource-dev-autofix[bot] wants to merge 1 commit into
Open
refactor: escape import output to prevent stored xss#2deepsource-dev-autofix[bot] wants to merge 1 commit into
deepsource-dev-autofix[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that user‐supplied data is properly escaped before being rendered, mitigating the risk of stored cross‐site scripting (XSS).
Changes include:
print_r($data, true)directly withinecho sprintf(), which allowed malicious HTML or script tags to be injected into the page. We now wrap the output inhtmlspecialchars(..., ENT_QUOTES, 'UTF-8')to encode special characters, converting<,>,&, and quotes into safe HTML entities.Security configuration:
ENT_QUOTESand specified the charset asUTF-8inhtmlspecialchars. This ensures both single and double quotes are escaped and that the encoding matches the application’s expected character set. We assumed the project uses UTF-8; please verify this matches your environment and adjust if necessary.