refactor: update encryption configuration to secure AES/CBC/PKCS5Padding - #2
Open
deepsource-dev-autofix[bot] wants to merge 1 commit into
Open
refactor: update encryption configuration to secure AES/CBC/PKCS5Padding#2deepsource-dev-autofix[bot] wants to merge 1 commit into
deepsource-dev-autofix[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the encryption logic to enforce a strong, well-known cipher mode and key specification. All instances of a generic or potentially insecure cipher configuration have been replaced with an explicit AES/CBC/PKCS5Padding setup.
The original code relied on OpenmrsConstants.ENCRYPTION_CIPHER_CONFIGURATION, which may default to weak or outdated algorithms. We now call Cipher.getInstance("AES/CBC/PKCS5Padding") to guarantee a secure cipher mode with PKCS#5 padding. Likewise, the SecretKeySpec is initialized with the "AES" algorithm to avoid ambiguity and ensure compatibility with AES key lengths.
Security configuration: Explicitly specifying "AES/CBC/PKCS5Padding" strengthens confidentiality and padding integrity. We assumed a 128- or 256-bit AES key and that IVs are securely generated elsewhere; please verify your key size and IV management align with your security policy.