refactor: replace risky RijndaelManaged with Aes - #2
Open
deepsource-dev-autofix[bot] wants to merge 2 commits into
Open
refactor: replace risky RijndaelManaged with Aes#2deepsource-dev-autofix[bot] wants to merge 2 commits into
deepsource-dev-autofix[bot] wants to merge 2 commits into
Conversation
|
Here's the code health analysis summary for commits Analysis Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of the legacy RijndaelManaged class with the standard Aes implementation and ensures that all cryptographic objects are properly disposed. The changes improve security by using AES with secure defaults and eliminating a potentially broken or risky algorithm.
The code originally instantiated a RijndaelManaged cipher, which supports nonstandard block sizes and may not receive the same level of security scrutiny as the AES class. We now call Aes.Create(), assign the existing key and IV, and wrap streams in using statements to ensure proper disposal. This guarantees use of AES with a 128-bit block size, default CBC mode, and PKCS7 padding, removing reliance on a weaker or poorly supported algorithm.
No explicit security configuration values were added beyond leveraging Aes.Create() defaults. We assume the provided key (192-bit) and IV (128-bit) lengths are correct; please review these values and update if a different key size or authenticated encryption mode (e.g., GCM) is required.