refactor: avoid direct use of Object.prototype builtins - #6
Open
deepsource-autofix[bot] wants to merge 1 commit into
Open
refactor: avoid direct use of Object.prototype builtins#6deepsource-autofix[bot] wants to merge 1 commit into
deepsource-autofix[bot] wants to merge 1 commit into
Conversation
**Fixes are generated by AI. Review them carefully before applying to your codebase.** This PR replaces direct invocations of built-in methods on objects with safe, unbound references to prevent unexpected behavior when those methods are overridden. - `Object.prototype builtins should not be used directly`: DeepSource flagged the direct use of methods like `obj.hasOwnProperty(key)` because an object’s own properties can shadow built-ins. We refactored these calls to use `Object.prototype.hasOwnProperty.call(obj, key)` (or `Object.hasOwn(obj, key)` where supported) to ensure reliability and security.
|
Here's the code health analysis summary for commits Analysis Summary
|
|
Here's the code health analysis summary for commits Analysis Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes are generated by AI. Review them carefully before applying to your codebase.
This PR replaces direct invocations of built-in methods on objects with safe, unbound references to prevent unexpected behavior when those methods are overridden.
Object.prototype builtins should not be used directly: DeepSource flagged the direct use of methods likeobj.hasOwnProperty(key)because an object’s own properties can shadow built-ins. We refactored these calls to useObject.prototype.hasOwnProperty.call(obj, key)(orObject.hasOwn(obj, key)where supported) to ensure reliability and security.