Skip to content

[Do not merge] Make changes in the code #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srijan-deepsource wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[Do not merge] Make changes in the code #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
af5c73a
Make changes in the code
sauravsrijan Jan 13, 2023
2fcbbf5
More changes
sauravsrijan Jan 13, 2023
ab2bd42
Merge branch 'master' into implement-feature-x
srijan-deepsource Jan 30, 2023
838c2e1
Update UrlRequest.java
raghav-deepsource Jan 30, 2023
92feed7
Apply suggestions from code review
raghav-deepsource Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions csharp/Antipattern.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,13 @@ public static void CommonAntipatterns()
{

}

if (emptyString == "")
{
Console.WriteLine("String is empty!");
}

var myCmp = s1.ToLower() == s2.ToLower();

object o = new Foo();
var foo = o as Foo;
Expand Down
2 changes: 0 additions & 2 deletions docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ FROM alpine

USER root

RUN apk update && apk add postgresql curl
RUN mkdir /app
COPY --from=builder /home/postgres /app

# To be used in the container.
Expand Down
5 changes: 5 additions & 0 deletions java/multiModule1/subMultiModule1/src/main/java/com/example/api/UrlRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@ public UrlRequest(URL url, Map<String, String> params) {
params = params;
}

public void setApiRequestData(URL url, Map<String, String> params) {
url = url;
params = params;
}

/**
* Performs a network request and returns the data sent in the response.
*
Expand Down
4 changes: 0 additions & 4 deletions python/complex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ def __init__(self, x, y):
def __add__(self, other):
return self.val + other.val

def __radd__(self, other):
res = (self.x + other.val, self.y)
return res


if __name__ == "__main__":
complex_num = ComplexNumber(2, 5)
Expand Down
4 changes: 0 additions & 4 deletions ruby/code.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,3 @@ def foo
my_hash = {}
# Raises "Hash merging can be replaced by hash key assignment"
my_hash.merge!('key': value)


# Raises "Use `size` instead of `count`"
[1, 2, 3].count
11 changes: 11 additions & 0 deletions sql/pkg/db.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,17 @@ SET row_security = off;

CREATE EXTENSION IF NOT EXISTS plpgsql WITH SCHEMA pg_catalog;

IMPORT INTO part CSV DATA(
'gs://sf-10/part.tbl.1',
'gs://sf-10/part.tbl.2',
'gs://sf-10/part.tbl.3',
'gs://sf-10/part.tbl.4',
'gs://sf-10/part.tbl.5',
'gs://sf-10/part.tbl.6',
'gs://sf-10/part.tbl.7',
'gs://sf-10/part.tbl.8'
) WITH delimiter='|';


--
-- Name: EXTENSION plpgsql; Type: COMMENT; Schema: -; Owner:
Expand Down