feat(home-v2): open saved start pages on launch - #353
Merged
Conversation
Implements F3 (decision #12 KEEP), the one roadmap item that was never built. planStartPageLaunch (pure, tested) mirrors the v1 rules: start pages apply only when the session would otherwise be just the dashboard (a restored session's tabs win), onboarding-in-progress suppresses them, and pages bound to a missing account fall back to the current account. The LiveApp effect is one-shot per process, fires at the first moment shell state and the collections snapshot are both ready, opens each page through the existing openAddress pipeline (failures skipped), and re-activates the first opened tab to match v1's first-page-active behavior. Parity review P-8 (projects/qortium-home-2.1/parity-review-2026-08-24). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parity review P-8 / roadmap F3 (decision #12: KEEP launch-tab restoration + start pages) — the only theme item that was never implemented. The F9 migration already carried the v1 start-pages data into the v2 collections store; this makes them do something again.
planStartPageLaunch(contract-tested in the foundation suite) encodes the v1 rules: start pages open only when the session would otherwise be just the dashboard — a restored session's tabs always win; onboarding-in-progress suppresses them; a page bound to an account that no longer exists opens with the current account (v1's fallback); blank entries are dropped; the MAX_START_PAGES cap applies.openAddresspipeline (a page that no longer resolves is skipped, not fatal), and the first start page ends up active, matching v1 — the loop then re-activatestabs[0]since fresh sessions start with zero app tabs.productStateReflive mirror; no new state shape, no persistence changes, no i18n changes.Testing
tscclean;test:home-v2-foundation(extended with the three plan cases: normal launch with dead-account fallback + blank filtering, restored-session suppression, onboarding suppression) passes;build:renderersucceeds. End-to-end acceptance: save 2+ start pages via the Bookmarks data, quit, relaunch — both open with the first active; relaunch with a restored session → no start pages.🤖 Generated with Claude Code