fix(home-v2): hide the toolbar pill of a disabled network - #352
Merged
Conversation
The per-network enable toggle (PR #340) gates dashboard cards, presence rows, and settings, but the top-bar network pills still rendered both networks unconditionally, showing a disabled network as a greyed pill. The pill row now filters out networks whose node mode is 'disabled', completing the brand-separation behavior the toggle promised. Foundation test extended to pin it. Parity review P-11 (projects/qortium-home-2.1/parity-review-2026-08-24). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parity review P-11 — the one residual the review found on the per-network toggle (PR #340): the top-bar pills rendered both networks unconditionally, so a disabled network still showed as a greyed pill. The pill row now filters out
mode === 'disabled'networks, matching the dashboard cards/presence/settings gating and completing the brand-separation behavior from the community feedback (PolarBear/Crinoid).One-line change plus a foundation-test assertion pinning that a disabled Qortal hides its pill while the Qortium pill stays.
Testing
test:home-v2-foundation(extended) passes;build:renderersucceeds.🤖 Generated with Claude Code