fix: stop calling the combined transport mode an I2P "fallback" - #249
Merged
Conversation
Since Core 1.6.3 the combined transport mode actively dials both IP and I2P with reserved outbound slots for the second transport (core PR #191), so "Direct + I2P fallback" is a misnomer. Rename the option to "Direct + I2P" and reword the Direct-only warning accordingly, in English and all 22 translations. Wording only, no behaviour change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The transport mode picker (Dashboard, Settings > Qortium Core, and the Welcome page all mount the same
TransportModeSelect) labels its default option "Direct + I2P fallback". Since Core 1.6.3 that mode is not a fallback: the node keeps active connections over both direct IP and I2P simultaneously, reserving outbound dial slots for the non-preferred transport (QortiumDev/qortium-core#191).connections.mode.default: "Direct + I2P fallback" → "Direct + I2P"connections.ipOnlyWarning: "Turns off the I2P fallback. …" → "Turns off I2P. …"Wording only — no behaviour change. Pairs with QortiumDev/qortium-node#16, which collapsed the Node app's transport setting to the same three capabilities, closing the Dashboard-vs-Settings mismatch Bebop reported.
Testing
npx tsc --noEmitclean (locale values only; theTranslationKeyunion is unchanged).npm test: 62/62 test scripts passed.🤖 Generated with Claude Code