fix(private-chat): use automatic Qortium group keys - #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the private-group send failure reproduced in Qortium group #4 while keeping Qortium key management automatic, adds the requested group ID labels, and closes two Android session regressions found during packaged Home acceptance.
The original diagnosis was correct that the selected member lacked a usable current-epoch key, but the first fix exposed the wrong product workflow. Qortium Core's QPGC design permits any current member to create an announcement and automatically does so on first send; Home 2's portable bridge had stopped at
MISSING_GROUP_KEY. Companion Home PR QortiumDev/qortium-home#306 now restores that automatic lifecycle on desktop and Android.stage: "key-announcement",messageSubmitted: falseresult as a definite message rejection with a safe Retry affordance, rather than claiming the message may already have been sent#<groupId>immediately before Qortium/Qortal and CHAT chips in group headers, and before CHAT in sidebar group rows*.qdn.androidplatform.netorigin and use the existing REST polling paths instead; desktop Home WebSockets remain enabledVerification
npm run buildnpm test— 53 test files, 736 tests passednpm run smoke:new-user#0 CHATand#7 CHAT#7 Qortium CHATnpm run smoke:gatewaynpm run smoke:hub-privatenpm run smoke:mobile-densitynpm run smoke:scrollNo version bump or QDN publication is included.
Manual acceptance
*.qdn.androidplatform.net/websockets/....