feat: treat GAME like APP and WEBSITE - #11
Merged
Conversation
A published GAME is browser content, exactly as an APP or a WEBSITE is: Home hosts all three through the same archive path (electron/qdn-browser-archive-services.ts). This app only recognised APP and WEBSITE, so a GAME fell through to the download-only branch — a real published game could be saved but not opened. Recognise all three together, from one named list rather than an inline pair, so the next service added to that set does not have to be chased through separate conditions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A published GAME is browser content, exactly as an APP or a WEBSITE is — Home hosts all three through the same archive path (
electron/qdn-browser-archive-services.ts). This app recognised only APP and WEBSITE, so a GAME fell through to the download-only branch.A bookmarked GAME was not recognised as a QDN address at all, so it got neither favicon resolution nor the publisher avatar fallback.
parseQdnAddressnow accepts it in either case.Mutation-checked: reverting the pattern fails the new assertion with
expected null to deeply equal { service: 'GAME', … }. 92 tests pass.Both services are now read from one named list rather than an inline pair, so the next service added to that set does not have to be chased through separate conditions.