Skip to content

fix: align react-dom with react so the app mounts - #18

Merged
QuickMythril merged 1 commit into
mainfrom
fix/react-dom-version-alignment
Jul 28, 2026
Merged

fix: align react-dom with react so the app mounts#18
QuickMythril merged 1 commit into
mainfrom
fix/react-dom-version-alignment

Conversation

@QuickMythril

Copy link
Copy Markdown
Member

The bug

ChibiHub 1.4.3 renders a blank page. The console shows:

Uncaught Error: Minified React error #527; args[]=19.2.8&args[]=19.2.7

Dependabot #13 bumped react to 19.2.8, but this repo has no matching react-dom PR, so react-dom stayed on 19.2.7. React 19 refuses to render a mismatched pair and throws at mount.

Why nothing caught it

Every existing check passed on the broken build:

  • the unit tests never mount through react-dom;
  • tsc --noEmit and vite build both succeed;
  • the published bundle byte-matched its source, so the publish verification was green too.

I audited all 30 local app repos with a lockfile — ChibiHub is the only mismatched one; every other app has react and react-dom on the same version.

The fix

  • react-dom → 19.2.8, matching react.
  • A test that compares the versions the bundle actually resolves (importing version from each package), not the declared ranges — a caret range would have hidden this.
  • Version bumped to 1.4.4 for the republish.

Verification

  • 120 tests pass; tsc and build clean.
  • Mutation-checked: pinning react-dom back to 19.2.7 fails the new test with expected '19.2.7' to be '19.2.8'.
  • Rendered the rebuilt app headlessly: it mounts and paints, with zero console errors.

A Dependabot bump moved react to 19.2.8 while react-dom stayed on 19.2.7.
React 19 refuses to render a mismatched pair: the published 1.4.3 build threw
"Minified React error #527" at mount and showed a blank page.

Nothing in the pipeline caught it. The unit tests never mount through
react-dom, `tsc --noEmit` and `vite build` both succeed, and the published
bundle byte-matched its source, so every existing check passed on a broken app.

Align react-dom to 19.2.8 and add a test that compares the versions the bundle
actually resolves, not the declared ranges. Verified by mutation: pinning
react-dom back to 19.2.7 fails the new test. The rebuilt app renders with no
console errors.
@QuickMythril
QuickMythril merged commit aa0291e into main Jul 28, 2026
4 checks passed
@QuickMythril
QuickMythril deleted the fix/react-dom-version-alignment branch July 28, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant