Hash comparison and sync timestamp - #31
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30:
Change 1 — Hash comparison before publishing (line 300-312)
When localLastUpdated > qdnLastUpdated, the code now computes both hashes before deciding anything. If they match, the address book content is identical and the publish is skipped entirely. The local timestamp is re-aligned to the QDN timestamp so future startups go straight to the cheaper equal-timestamps path.
qdnData.hash ?? generateHash(qdnData.entries) handles the case where older published data has no stored hash — in that case we compute it on the fly from the raw entries.
Change 2 — Sync local timestamp after a real publish (line 317-324)
When hashes genuinely differ and a publish is needed, the local lastUpdated is now written back to localStorage with the timestamp captured just before the publish. Previously this was never done, so local would always lag behind QDN and force an extra "QDN is newer" pass on the very next startup. Now both sides converge immediately.