feat(graphql): extract subscription error policy#866
Draft
stdevi wants to merge 4 commits into
Draft
Conversation
Move QminderGraphQLError and the non-retryable subscription-error classification into graphql-error.ts (re-exported from graphql.service for backward compatibility). Behaviour-preserving; protocol-agnostic pieces the library transport will reuse. No test changes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Move the retryable-subscription-error state machine out of GraphqlService into a transport-agnostic, callback-based RetryableSubscriptionErrorPolicy (retry / fail actions supplied by the service). Behaviour-preserving — same batch retry, 5-attempt limit, 500ms success grace, and haveAnyRetryableSubscriptionsErrored semantics. No test changes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
stdevi
changed the title
Move the retryable-subscription-error state machine out of GraphqlService into a transport-agnostic, callback-based RetryableSubscriptionErrorPolicy (retry / fail actions supplied by the service). Behaviour-preserving — same batch retry, 5-attempt limit, 500ms success grace, and haveAnyRetryableSubscriptionsErrored semantics. No test changes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…efactor-graphql-service # Conflicts: # packages/javascript-api/src/lib/services/graphql/graphql.service.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.