Skip to content

Add license metadata to pyproject.toml#1623

Merged
IvanIsCoding merged 1 commit into
Qiskit:mainfrom
johnthagen:license-metadata
Jul 1, 2026
Merged

Add license metadata to pyproject.toml#1623
IvanIsCoding merged 1 commit into
Qiskit:mainfrom
johnthagen:license-metadata

Conversation

@johnthagen

Copy link
Copy Markdown
Contributor

Closes #1622

@CLAassistant

CLAassistant commented Jun 30, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@johnthagen

Copy link
Copy Markdown
Contributor Author

I'll probably pass on signing a CLA for something this tiny, but any maintainer is welcome to make this fix on their own.

@IvanIsCoding

Copy link
Copy Markdown
Collaborator

I remember #1494 explicitly removed this, there was a warning that field was deprecated. I will read more on the subject and see what other projects are doing

@IvanIsCoding

Copy link
Copy Markdown
Collaborator

Apparently I misunderstood https://peps.python.org/pep-0639/#deprecate-license-field. The PR is right, I just need to understand the warning that was being given before. I will merge this in a separate PR.

@jakelishman

Copy link
Copy Markdown
Member

Ivan: maybe you're mixing up the differences between the field names in the wheel "core metadata" fields and how the information is read in from pyproject.toml (or equivalents) by Python build backends? That was my confusion when I read the PEP, at least - they've all got similar names, but there's nothing formally requiring there to be a 1:1 link between them.

@IvanIsCoding

Copy link
Copy Markdown
Collaborator

Ivan: maybe you're mixing up the differences between the field names in the wheel "core metadata" fields and how the information is read in from pyproject.toml (or equivalents) by Python build backends? That was my confusion when I read the PEP, at least - they've all got similar names, but there's nothing formally requiring there to be a 1:1 link between them.

Yeah I mixed things up, the summary of it is: maturin should generate the right metadata if we merge this PR. The fix is right. I will confirm with pip-licenses

@IvanIsCoding IvanIsCoding enabled auto-merge July 1, 2026 00:58
@IvanIsCoding IvanIsCoding added this pull request to the merge queue Jul 1, 2026
@mergify

mergify Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Merged via the queue into Qiskit:main with commit 2478985 Jul 1, 2026
40 checks passed
@johnthagen johnthagen deleted the license-metadata branch July 1, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

License metadata missing from 0.18.0 wheel

4 participants