Skip to content

Fix split_layers description in CollectCliffords - #16837

Merged
jakelishman merged 3 commits into
Qiskit:mainfrom
josemmiranda04:fix-collectcliffords-split-layers-docstring
Aug 28, 2026
Merged

Fix split_layers description in CollectCliffords#16837
jakelishman merged 3 commits into
Qiskit:mainfrom
josemmiranda04:fix-collectcliffords-split-layers-docstring

Conversation

@josemmiranda04

@josemmiranda04 josemmiranda04 commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Fix #16833

It uupdates the split_layers argument description in CollectCliffords to clarify that collected blocks are split into layers of non-overlapping instructions, in other words, depth-1 sub-blocks.

Validation:

  • python -m compileall qiskit/transpiler/passes/optimization/collect_cliffords.py

AI/LLM disclosure

  • No part of this submission is LLM generated.
  • Some written text was generated by: Claude
  • Some submitted code was generated by:

@josemmiranda04
josemmiranda04 requested a review from a team as a code owner August 26, 2026 11:34
@CLAassistant

CLAassistant commented Aug 26, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@jakelishman

Copy link
Copy Markdown
Member

Please confirm you have accurately filled out the LLM disclosure.

@ShellyGarion ShellyGarion added the documentation Something is not clear or an error documentation label Aug 27, 2026
@josemmiranda04

Copy link
Copy Markdown
Contributor Author

Please confirm you have accurately filled out the LLM disclosure.

Already accurately filled. Thank you for the feedback!

@jakelishman jakelishman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that there is a box ticked, but the writing is highly suggestive that an LLM authored the entire PR as well as the description, which is why I asked.

@jakelishman
jakelishman enabled auto-merge August 28, 2026 10:32
@jakelishman jakelishman added stable backport potential Make Mergify open a backport PR to the most recent stable branch on merge. Changelog: None Do not include in the GitHub Release changelog. labels Aug 28, 2026
@jakelishman
jakelishman added this pull request to the merge queue Aug 28, 2026
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 33162310476

Coverage increased (+0.004%) to 87.747%

Details

  • Coverage increased (+0.004%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 11 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

11 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
crates/qasm2/src/parse.rs 6 97.63%
crates/qasm2/src/lex.rs 5 92.03%

Coverage Stats

Coverage Status
Relevant Lines: 131079
Covered Lines: 115018
Line Coverage: 87.75%
Coverage Strength: 982413.25 hits per line

💛 - Coveralls

Merged via the queue into Qiskit:main with commit 255ebc1 Aug 28, 2026
33 checks passed
@josemmiranda04
josemmiranda04 deleted the fix-collectcliffords-split-layers-docstring branch August 28, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelog: None Do not include in the GitHub Release changelog. documentation Something is not clear or an error documentation stable backport potential Make Mergify open a backport PR to the most recent stable branch on merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CollectCliffords docstring has same description for two different kwargs

5 participants