Remove NaN and Inf checks if __FINITE_MATH_ONLY__ is defined - #35
Draft
garrison wants to merge 1 commit into
Draft
Remove NaN and Inf checks if __FINITE_MATH_ONLY__ is defined#35garrison wants to merge 1 commit into
__FINITE_MATH_ONLY__ is defined#35garrison wants to merge 1 commit into
Conversation
Pull Request Test Coverage Report for Build 23369575181Details
💛 - Coveralls |
garrison
marked this pull request as draft
March 21, 2026 02:02
Member
Author
|
After further thought, I think we should disable these checks if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is motivated by qiskit-community/fulqrum#3. If finite-only math is used, then these checks are unnecessary, and we can remove them to spare the user some warnings.
However, I am hesitant to go out of my way much to support compilers that have been instructed to break IEEE 754 semantics, so I am still considering whether it makes sense to merge this.
__FAST_MATH__is defined?