Skip to content

Correct actor-value virtual mappings #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Quantumyilmaz wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Correct actor-value virtual mappings #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ec5325
Fix ActorValueOwner overload dispatch
Quantumyilmaz Jul 17, 2026
f2e30c9
Map Actor value adjustment virtual
Quantumyilmaz Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/RE/A/Actor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ namespace RE
virtual void Unk_19A(); // 19A
virtual void Unk_19B(); // 19B
virtual void Unk_19C(); // 19C
virtual void Unk_19D(); // 19D
virtual float Unk_19D(const ActorValueInfo& a_info, float a_delta); // 19D
virtual void Unk_19E(); // 19E
virtual void Unk_19F(); // 19F
virtual void Unk_1A0(); // 1A0
Expand Down
3 changes: 2 additions & 1 deletion include/RE/A/ActorValueOwner.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,14 @@ namespace RE
virtual ~ActorValueOwner(); // 00

// add
// MSVC emits the ModActorValue overloads in reverse vtable order; keep their declarations reversed so calls use the documented slots.
virtual float GetActorValue(const ActorValueInfo& a_info); // 01
virtual float GetPermanentActorValue(const ActorValueInfo& a_info); // 02
virtual float GetBaseActorValue(const ActorValueInfo& a_info); // 03
virtual void SetBaseActorValue(const ActorValueInfo& a_info, float a_value); // 04
virtual void ModBaseActorValue(const ActorValueInfo& a_info, float a_delta); // 05
virtual void ModActorValue(ACTOR_VALUE_MODIFIER a_modifier, const ActorValueInfo& a_info, float a_delta, TESObjectREFR* a_ref); // 06 - new
virtual void ModActorValue(ACTOR_VALUE_MODIFIER a_modifier, const ActorValueInfo& a_info, float a_delta); // 07
virtual void ModActorValue(ACTOR_VALUE_MODIFIER a_modifier, const ActorValueInfo& a_info, float a_delta, TESObjectREFR* a_ref); // 06
virtual float GetModifier(ACTOR_VALUE_MODIFIER a_modifier, const ActorValueInfo& a_info); // 08
virtual void RestoreActorValue(const ActorValueInfo& a_info, float a_amount); // 09
virtual void SetActorValue(const ActorValueInfo& a_info, float a_value); // 0A
Expand Down