Remove hardcoded Qidi Max 4 input shaper - #193
Open
thelegendtubaguy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes hard coding the X and Y input shaper algo for the Qidi Max 4. The Qidi Max 4 has input shaping and the machine not only determines the value, but also the algorithm. There's nothing I can find that would give me a reason as to why this should be hard coded. No other QidiStudio profiles do this.
Tests
Without these being set explicitly, the printer will load the already saved input shaper values and algos that were determined during machine calibration. One caveat to this, Qidi will also need to update the Klipper configs on the machine which also hard code this value during the stock
print_startsequence for some reason.