Fix getLocalTimestamp#82
Open
CuberL wants to merge 1 commit into
Open
Conversation
GeorgeTG
added a commit
to GeorgeTG/garmin-connect
that referenced
this pull request
Apr 12, 2026
- ActivityType.Running: 'street_running' → 'running' (was using the
sub-type value instead of the parent type key, causing getActivities
with ActivityType.Running to return wrong results)
- getLocalTimestamp: replace double new Date() round-trip with
toLocaleDateString/toLocaleTimeString('sv') approach which correctly
applies the timezone without lossy locale string re-parsing
(fixes updateWeight logging entries at wrong timestamps)
Fixes upstream issues Pythe1337N#79 and Pythe1337N#82
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I noticed that the implementation of the
getLocalTimestampmethod used inupdateWeightseems problematic. As I understand it, this method is intended to generate an ISO format event string for a specified timezone. TakingAmerica/Los_Angeles(GMT-8) as an example, for the UTC time2024-12-10T18:00:00.000Z, the expected result should be2024-12-10T10:00:00.000. However, the method currently returns2024-12-09T18:00:00.000. As a result, the recorded date in Garmin Connect is December 9th, and the time is incorrect.To address this, I have reimplemented the method. For the same case, the result will now be
2024-12-10T10:00:00.000.The
svlanguage was chosen because Swedish uses ISO strings as its time representation format.