Add get_available_criteria#131
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
get_available_criteriafor returning available goodness-of-fit statistic classes and move short-code lookup toget_available_criteria_codes.Quick changelog
get_available_criteriabehavior toget_available_criteria_codes.get_available_criteriamethod returning concreteAbstractGoodnessOfFitStatisticsubclasses.What's new?
This PR separates two related utility behaviors:
get_available_criteria(distribution)now returns the available non-abstract goodness-of-fit statistic classes for the requested distribution.get_available_criteria_codes(distribution)preserves the previous behavior and returns the list of statistic short codes.The implementation also explicitly imports
pysatl_criterion.statistics.goodness_of_fitbefore walkingAbstractGoodnessOfFitStatistic.__subclasses__(), so criteria discovery no longer depends on prior import order.Validation added in
tests/utils/test_statistic.pychecks that:AbstractGoodnessOfFitStatistic;