fix(families): raise ValueError for x outside support in builtins#118
Open
MyznikovFD wants to merge 1 commit into
Open
fix(families): raise ValueError for x outside support in builtins#118MyznikovFD wants to merge 1 commit into
MyznikovFD wants to merge 1 commit into
Conversation
MyznikovFD
requested review from
Desiment and
LeonidElkin
and removed request for
LeonidElkin
May 25, 2026 16:00
MyznikovFD
added
Bug
LeonidElkin
reviewed
May 31, 2026
LeonidElkin
left a comment
LeonidElkin
left a comment
Collaborator
There was a problem hiding this comment.
The issue explicitly lists normal.py, but this commit does not add any support validation for the normal score. Even though all finite real values are in support, ContinuousSupport() excludes ±inf and NaN, and the current implementation returns inf/nan gradients for those inputs. Either add a finite-value check here or clarify why normal is intentionally out of scope.
MyznikovFD
force-pushed
the
score-function
branch
3 times, most recently
from
July 17, 2026 13:32
b8b7845 to
61d8608
Compare
MyznikovFD
changed the title
Merged
LeonidElkin
previously approved these changes
Jul 19, 2026
MyznikovFD
force-pushed
the
score-function
branch
from
July 21, 2026 16:49
61d8608 to
6693238
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.