Conversation
Use a local rd variable when decoding MOV immediate to avoid duplicating the bit extraction expression and to clarify intent. Set the negative (N) flag based on the signed interpretation of the loaded value instead of always clearing it. Add unit tests covering: - writes to SP clear the lower two bits - writes to PC clear the least significant bit - register-to-register moves for positive and negative values These tests increase coverage for MOV behavior and verify flag and special-register handling.
|
begeistert
changed the title
lmSeryi
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
rdvariable when decoding MOV immediate to avoid duplicating the bit extraction expression and clarify intent.Type of change
Checklist
dotnet test)Screenshots / Hex Dumps (Optional)