Remove pynufft references following its removal from PyAutoArray - #497
Merged
Conversation
`TransformerNUFFTPyNUFFT` no longer exists, so the prose describing it as a "non-JAX fallback" is dead. Several of these passages were already stale before this change: they described `TransformerNUFFT` as pynufft-backed and not JAX-traceable, which stopped being true at the nufftax migration. - `scripts/interferometer/start_here.py` — the `__JAX__` section claimed `TransformerNUFFT` (pynufft) was not JAX-traceable and that nufftax was a "research path". Both transformers are JAX-traceable; nufftax is the shipped backend. - `scripts/guides/using_jax.py`, `scripts/interferometer/simulator.py`, `scripts/interferometer/features/linear_light_profiles/modeling.py` — dropped the legacy-fallback clauses. - `start_here.py` — the feature blurb cited PyNUFFT as the uv-plane NUFFT; now cites nufftax. Where the removed text pointed at a non-JAX fallback, the replacement names the real constraint instead: nufftax requires JAX, which has no wheels for Intel macOS, so `TransformerDFT` is the option there. `notebooks/` and `markdown/` carry the same prose and are regenerated from `scripts/` at release time; the equivalent edits are applied here directly so they are not stale in the interim. Notebook JSON was edited in place rather than round-tripped, to avoid reformatting churn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workspace follow-up to PyAutoLabs/PyAutoArray#475 (merged), which removed
TransformerNUFFTPyNUFFTand thepynufftdependency.The prose describing that class as a "non-JAX fallback" now points at something that does not exist. Several of these passages were already stale before this change: they described
TransformerNUFFTas pynufft-backed and not JAX-traceable, which stopped being true at the nufftax migration.scripts/interferometer/start_here.py— the__JAX__section told readers to useTransformerDFTbecause "TransformerNUFFT(pynufft) … is not JAX-traceable" and called nufftax "a research path". Both transformers are JAX-traceable and nufftax is the shipped backend.scripts/guides/using_jax.py,scripts/interferometer/simulator.py,scripts/interferometer/features/linear_light_profiles/modeling.py— dropped the legacy-fallback clauses.start_here.py— the feature blurb cited PyNUFFT as the uv-plane NUFFT; now cites nufftax.Where the removed text pointed readers at a non-JAX fallback, the replacement names the real constraint instead: nufftax requires JAX, which ships no wheels for Intel macOS (jaxlib's last x86_64 macOS wheel was 0.4.38, Dec 2024, and jaxlib has never shipped an sdist), so
TransformerDFTis the option there.Scripts Changed
start_here.pyscripts/interferometer/start_here.pyscripts/interferometer/simulator.pyscripts/interferometer/features/linear_light_profiles/modeling.pyscripts/guides/using_jax.pynotebooks/andmarkdown/carry the same prose and are regenerated fromscripts/at release time. The equivalent edits are applied here directly so they are not stale in the interim — the nextpre_buildregeneration produces the same text. Notebook JSON was edited in place rather than round-tripped through a parser, so the diffs stay surgical (5 lines) instead of reformatting whole files.Test Plan
pynufft/PyNUFFT/TransformerNUFFTPyNUFFTreferences remain anywhere in the repoGenerated by Claude Code