Skip to content

fix(looting_on_shears): allow looting on spears - #39

Merged
RhythmicSys merged 1 commit into
PurpurMC:masterfrom
inwerk:fix-looting-spears
Sep 4, 2026
Merged

RhythmicSys merged 1 commit into
PurpurMC:masterfrom
inwerk:fix-looting-spears

Conversation

@inwerk

@inwerk inwerk commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

Fixes: #37

Restore Looting enchantment support for spears by adding #minecraft:spears to the looting.json tag.

@JanTuck JanTuck left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not like the looting on shears having the spears added to it. It just seems wrong to me, but oh well. Nice job.

@kacimiamine

Copy link
Copy Markdown

@JanTuck Spears support looting enchantments by default in vanilla (without a datapack, same as swords), so when using this datapack, it removes that possibility, therefore why this fix is made.

TLDR, it's not an addition, it's a bug fix.

@kacimiamine

Copy link
Copy Markdown

@RhythmicSys

Copy link
Copy Markdown
Collaborator

Apologies on taking so long to approve this PR

@RhythmicSys
RhythmicSys merged commit 89b2c34 into PurpurMC:master Sep 4, 2026
@LargoGitH

LargoGitH commented Oct 1, 2026 •

Copy link
Copy Markdown

Hi, it seems like this has only been merged into the jar form of the 1.21.11 datapack? The zip doesn't contain spears

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Looting Shears datapack prevents applying Looting to Spears

5 participants