Repository navigation
Fix Windows capture paths and public WebSocket text subscriptions - #35
Merged
Merged
Conversation
PureSaber
commented
Oct 10, 2026
PureSaber
left a comment
Owner
Author
There was a problem hiding this comment.
Reviewed the changed storage and transport paths at this head. Extended local-drive paths resolve only the device anchor; unsupported Windows anchors still reject before probing. Subscription payloads remain byte-compatible at the internal interface while a real local WebSocket verifies a UTF-8 text frame on the wire. Full local tests/coverage and lint/format/pip check passed. No blocking finding remains from this review. This is the implementing agent's review, not an independent human approval; CI is checked separately before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture failed when Windows extended-length drive paths reached the physical-volume probe, and public subscription JSON was sent as a binary WebSocket frame. Normalize only the volume-device anchor while retaining extended file paths, and send subscription JSON as UTF-8 text. UNC/device paths and OS-denied probes still fail closed.
Validation: 863 tests passed, 2 skipped; Ruff lint/format and pip check passed. All tracked branch coverage is 83.13% (80% gate), every core module clears its 90% gate. A real local WebSocket round trip verifies text frames; Windows anchor tests cover both accepted spellings and rejected non-drive paths. No issue is required for these acceptance-driven fixes; no market data or credentials are included.