Skip to content

filereader: don't allocate on every yieldLine call #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BaruchWeka wants to merge 1 commit into
base: master
Choose a base branch
from
Open

filereader: don't allocate on every yieldLine call #426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lsp/source/served/lsp/filereader.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,14 +265,18 @@ abstract class FileReader : Thread

string yieldLine(bool* whileThisIs = null, bool equalToThis = true)
{
// hoisted: as a literal this allocates on every call, and this runs once
// per main loop iteration even when idle
static immutable ubyte[2] crlf = [cast(ubyte) '\r', cast(ubyte) '\n'];

ptrdiff_t index;
string ret;
while (whileThisIs is null || *whileThisIs == equalToThis)
{
bool hasData;
synchronized (mutex)
{
index = data.countUntil([cast(ubyte) '\r', cast(ubyte) '\n']);
index = data.countUntil(crlf[]);
if (index != -1)
{
ret = cast(string) data[0 .. index].dup;
Expand Down
Loading