jsonrpc: allow a timeout on requestMessage, use it for the DCD prompt - #425
Open
BaruchWeka wants to merge 4 commits into
Open
jsonrpc: allow a timeout on requestMessage, use it for the DCD prompt#425BaruchWeka wants to merge 4 commits into
BaruchWeka wants to merge 4 commits into
Conversation
Clients need not answer showMessageRequest. A fiber waiting on one that never comes lives for the rest of the process and keeps the main loop from going idle. Give the DCD update prompt 10 minutes. (cherry picked from commit f18d73f3c4cc56c928d583db20be407c7db7be1e)
resolveWait threw without marking the slot handled, so prepareWait could never reuse it. Only reachable now that callers pass a finite timeout. (cherry picked from commit 35c9b3acdef5fc006609fb2206419eb39608ae8f)
Same parked-fiber problem; giving up skips the subproject, as dismissing the prompt does. (cherry picked from commit 836b6e085c28b3ab1fbabd646e852b972d6fdcb6)
Same parked-fiber problem; giving up downloads nothing, as dismissing the prompt does. (cherry picked from commit 80b4b3325f6adade1e5f88ca7934d37cb5a114ad)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clients need not answer showMessageRequest. A fiber waiting on one that
never comes lives for the rest of the process and keeps the main loop from
going idle. Give the DCD update prompt 10 minutes.
(cherry picked from commit f18d73f3c4cc56c928d583db20be407c7db7be1e)