resolve the issues related to ProverRegistry and AttestationVerifier on OZ Audit report - #40
Open
chzyer wants to merge 4 commits into
Open
resolve the issues related to ProverRegistry and AttestationVerifier on OZ Audit report#40chzyer wants to merge 4 commits into
chzyer wants to merge 4 commits into
Conversation
1. AttestationVerifier: removed the redundant owner event. 2. ProverRegistry: use SafeCast for uint256 to uint64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Resolve the issues related to
ProverRegistryandAttestationVerifieron OZ Audit reportWhich issue(s) does this PR fixes:
Additional comments:
This is because the contract currently aligns with the behavior of other contracts.
For mock mode testing, the system is designed to bypass
attestation verification when the
dcapAttestationaddress is zero.We鈥檝e documented this behavior for clarity.