questionFeed: WTC UX design repass - uniform buttons, tap guard, rejected suggestion retention (#711, #715, #748) - #759
Open
WilfordGrimley wants to merge 4 commits into
Open
Conversation
…onous double-tap guards (#715) DESIGN-REPASS Rule 1 (#711): every action button on the WTC surface - the embedded custom triggers (tag question Apply/Not applicable, no-match reason strip Skip, artist picker candidate buttons) - now shares the spec's uniform metrics (min-height 44px, 15px/600, 6px 16px padding, --r-btn radius) via one new ActionButton primitive, instead of react-bootstrap's default geometry that read smaller than the feed's own Btn rows. Variants map to the surface palette (Apply=primary, Not applicable=secondary, Skip=ghost, artist consensus=success), matching the wtc-mockup's button mapping. Rule 2 (#715): synchronous in-flight refs in QueueTagQuestion, NoMatchReasonStrip and ArtistVotePicker close the double-tap window - the visual disabled flag only applies on the post-render, so a fast second tap could previously re-enter the vote handler and cast twice. The ActionButton also carries touch-action: manipulation (kills the mobile double-tap-zoom gesture that swallows single taps).
#748) Rejecting the suggested printing no longer drops it from the surface: the candidate grid regains it as a de-emphasised tile (dimmed, dashed outline, 'you said no - tap to reconsider' note) that stays fully selectable, the reconsider path for a mis-tapped 'No, different printing'. Rejected candidates never join illustration clusters (a cluster renders one representative tile, which would silently bury them again) and the singleton 'none left' state is now decided by candidate count rather than grid count, since the rejected suggestion is a grid member again. CardPanel: .rejected tile style + .rej caption note. QuestionFeed.test: new jest coverage for the grid inclusion + reconsider click. Playwright: the two #728-era 'never a selectable tile again' assertions now expect the de-emphasised data-rejected tile to remain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DESIGN-REPASS-2026-08.md.Test plan
npm run build).