Record PR #466's per-surface CI gating as an extractable primitive - #471
Merged
Conversation
Owner-directed: web-ci.yml's changes job + per-job if: conditions (plain git diff, no third-party action) is a portable pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Owner-directed, records PR #466's CI scoping. PR #466 (merged 2026-07-25) added a
changesjob to.github/workflows/web-ci.ymlthat does a plaingit diff --name-onlyagainst the push's pre-image SHA (no third-party paths-filter action), gatingtest-backend/test-frontend/merge-frontend-test-reports/build-frontendbehind per-jobif:conditions so a backend-only merge no longer runs the full 4-shard Playwright suite (and vice versa).Verified by reading
.github/workflows/web-ci.ymlon master directly: pure workflow YAML + plaingit diff/grep, zerocardpicker.*/vote-system/consensus/auth reference — qualifies as CLEAN. Added one row + a detail note todocs/upstreaming/extractable-primitives.md's "Docs tooling & federation" table, marked pattern-level (the job/path names are fork-specific; thechanges-job +if:-wiring shape is what generalizes), same precedent as the existing "Eager-WASM lazy-mount fix" and "Deterministic snapshot-test sequencing" rows. The note also distinguishes this fromcoverage-delta.yml, which deliberately stays unfiltered per its own header comment (issue #415/incident #389) — not a second instance of the pattern, not an oversight.docs/upstreaming/conventions.md's "CI for the ladder" section was checked but NOT edited: that section describesupstream-branch-verification.yml/upstream-drift-monitor.yml, which trigger only viaschedule/workflow_dispatchand always run the full pre-commit + backend pytest suite regardless of surface —web-ci.yml's per-surface gating never applies to them (upstream-fix-/upstream-feat- branches aren't pushed tomasterand don't carry the workflow file at all). Adding "upstream branches inherit path-scoped CI" there would misstate the mechanism, so this file was left untouched.Checklist
docs/upstreaming/extractable-primitives.md— new row + detail note for the per-surface CI gating pattern, judged CLEAN by hand (the mechanical tether only parses.py/.ts/.tsxfiles, so a.ymlrow isn't covered by it)docs/upstreaming/conventions.md— reviewed, deliberately not edited (see Description)python3 .github/scripts/docs_lint.py --strict— cleanpython3 .github/scripts/tests/test_docs_lint.py— 26 passedpython3 .github/scripts/tests/test_publish_wiki_link_rewrite.py— 4 passedpython3 .github/scripts/tests/test_publish_readme.py+ regenerate-and-diff — 8 passed, no driftpython3 .github/scripts/tests/test_check_protected_core_license.py+check_protected_core_license.py— cleannpx prettier@2.7.1 --check/pre-commit run --all-files— cleanNot a policy/wiki-published page — no "Last updated" marker to bump.