Skip to content

Compact the shared filter-panel controls to the approved density - #409

Merged
WilfordGrimley merged 2 commits into
masterfrom
modal-filter-density
Jul 24, 2026
Merged

Compact the shared filter-panel controls to the approved density#409
WilfordGrimley merged 2 commits into
masterfrom
modal-filter-density

Conversation

@WilfordGrimley

Copy link
Copy Markdown

The grid-selector "Card details" modal and Search Settings share seven filter components (SourceSettings, ResolvedAttributeFilter, MatureContentFilter, CompressedFilter, SourceBackendFilter, SearchTypeSettings, ViewSettings) that still rendered stock Bootstrap: grey Table variant="secondary", 38px full-width md toggles, full-size buttons — the owner's "grey and massive" report (2026-07-24 mobile screenshots). The /display rail got the approved density; these shared panels never did.

Changes (density/theme only, zero behavior):

  • New CompactToggleHeight (31px) + SourceToggleWidth (88px) constants; ToggleButtonHeight (38px) remains the rail's binding value, explicitly documented as distinct.
  • All seven components: toggles → size sm, 31px, full-width-but-short (filter toggles) or 88px (per-source On/Off).
  • SourceSettings table: grey secondary variant → dark panel tokens (#22303f, rgba border), 14px, size="sm"; "Disable/Enable all drives" → size="sm".

Verified: tsc clean, jest 568/568, prettier clean, 390px Playwright screenshots of the modal filter panel (attrs + sources) reviewed by owner.

wiki: search-settings/grid-selector docs need no content change (visual density only).

🤖 Generated with Claude Code

@WilfordGrimley

Copy link
Copy Markdown
Author

Second commit: the rail's Filters disclosure no longer embeds the stock SourceSettings table or ResolvedAttributeFilter toggle bars — the rail's own SOURCES accordion and Treatment/Frame/Border chip fieldset are the designed versions of both (SPEC-display-left-rail.md). Additive exclusions only; the classic grid-selector modal and Search Settings keep the stock panels (now compacted per commit 1). Verified: tsc, jest, prettier, 390px screenshots.

@WilfordGrimley
WilfordGrimley merged commit edbb727 into master Jul 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant