Compact the shared filter-panel controls to the approved density - #409
Merged
Conversation
Author
|
Second commit: the rail's Filters disclosure no longer embeds the stock SourceSettings table or ResolvedAttributeFilter toggle bars — the rail's own SOURCES accordion and Treatment/Frame/Border chip fieldset are the designed versions of both (SPEC-display-left-rail.md). Additive exclusions only; the classic grid-selector modal and Search Settings keep the stock panels (now compacted per commit 1). Verified: tsc, jest, prettier, 390px screenshots. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The grid-selector "Card details" modal and Search Settings share seven filter components (SourceSettings, ResolvedAttributeFilter, MatureContentFilter, CompressedFilter, SourceBackendFilter, SearchTypeSettings, ViewSettings) that still rendered stock Bootstrap: grey
Table variant="secondary", 38px full-width md toggles, full-size buttons — the owner's "grey and massive" report (2026-07-24 mobile screenshots). The /display rail got the approved density; these shared panels never did.Changes (density/theme only, zero behavior):
CompactToggleHeight(31px) +SourceToggleWidth(88px) constants;ToggleButtonHeight(38px) remains the rail's binding value, explicitly documented as distinct.size="sm"; "Disable/Enable all drives" →size="sm".Verified: tsc clean, jest 568/568, prettier clean, 390px Playwright screenshots of the modal filter panel (attrs + sources) reviewed by owner.
wiki: search-settings/grid-selector docs need no content change (visual density only).
🤖 Generated with Claude Code