Rebuild /display left rail for editor-completion Phase 1 fidelity - #318
Closed
WilfordGrimley wants to merge 2 commits into
Closed
Rebuild /display left rail for editor-completion Phase 1 fidelity#318WilfordGrimley wants to merge 2 commits into
WilfordGrimley wants to merge 2 commits into
Conversation
Filters collapsed by default, Select Version promoted/always-open with stacked full-width disclosure, artist + confidence line promoted above the fold, Card Details/Printing Tags/Report demoted to lazy-mounted accordion sections, and dark (never-white) empty/loading/failed slot states with a deterministic Scryfall "Find this card" link. CardDetailedViewModal body extracted into CardDetailedViewBody so the rail's demoted sections and the /editor modal share one implementation; modal visual spec passes unmodified as the extraction's proof. No interactions (context menu/drag/multi-select/undo) - Phase 2.
…hase1-left-rail # Conflicts: # docs/troubleshooting.md
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 of the owner-approved editor-completion package (authority: the editor-completion spec + mockup scoped in #244) — the left-panel fidelity rebuild on
/display. Visual foundation only; no interactions.initialSettingsVisibleonuseGridSelectorSearch), full-width stacked disclosure (additivelayout="stacked"onSelectVersionResults, additivehiddenSectionsonGridSelectorFilters), Group-by/Facet removed from the rail, card-display-style toggle removed (compressed hard-pinned true), artist line + a confidence-element placeholder promoted always-visible above the fold.CardDetailedViewModal's body extracted intoCardDetailedViewBody.tsx(behavior-preserving, region-level sub-blocks: identifier copy, meta table, download/favorite, printing tags, report). The rail's demoted Card Details/Printing Tags/Report sections reuse the same sub-blocks, lazy-mounted so opening a slot doesn't fire their backend fetches until the section is actually expanded.<img>(kills the white pre-paint flash), an animated loading bar, and a failed state with a muted ✗ plus a deterministic Scryfall "Find this card ↗" link (zero-crawl: URL constructed from the query, never fetched).upstream/master'sPDF.tsx) already has the corner-only geometry (CutLineCorner,cutLineShape: "InsideOnly") — built the screen-side guide on that existing shape rather than reinventing it. True PDF-side color/preset parity is not shipped in this PR (see Deviations).All shared-component changes are additive-optional props; existing callers (
GridSelectorModal) are unaffected.Deviations from spec
ConfidenceElement.tsx) is the narrower placeholder the task explicitly scoped: no live vote dispatch, no Scryfall hover popover, and the "not this printing" button only renders for a suggested printing — the mockup also shows it for the confirmed state, which this PR does not replicate. D14 is flagged in the spec as needing further definition; this is a deliberate stopping point, not an oversight.origin/master) remain: a phone-viewport dialog-count race and the D17 sheet-position-pill race under scroll timing. The latter is documented indocs/troubleshooting.md.Test plan
npx tsc --noEmitcleannpx prettier@2.7.1 --checkclean on all changed filesnpx eslint --fixapplied,next lintcleanCardDetailedViewModal.visual.spec.tspasses unmodified — the extraction's acceptance proofDisplayPage.spec.tsupdated for the new rail structure (selectors moved, none loosened), passes except the pre-existing D17 flake noted aboveSelectVersionSection.spec.tsupdated (Filters now needs opening for the two filter-chip tests), passesDisplaySlotStates.spec.ts(4 tests) — asserts computedbackground-coloris never white across filled/loading/failed/empty-select-version states, plus the Scryfall link's presence; passesdocs/features/grid-selector.mdupdated in place for the rename/promotion;docs/troubleshooting.mdgained the D17 flake entryExtractable-primitives ledger: checked —
CardDetailedViewBody's sub-blocks (PrintingTagsBlock,ReportBlock) remain entangled with the tag-vote/consensus system, so this extraction does not produce a clean new ledger row. No ledger change made.Wiki checklist (merge-time)
/display(Editor) page needs a note that the left rail now opens with Select Version expanded and Filters collapsed, with Card Details/Printing Tags/Report moved into a demoted, lazy-loading accordion below it.Do not merge — awaiting owner review, per this task's explicit instruction (Phase 1 of a multi-phase package; interactions/context-menu/drag/multi-select/undo are Phase 2 and intentionally not built here).
Closes nothing (umbrella tracking against the editor-completion spec, not a single issue).