Skip to content

fix(custodian-sweep): raise per-repo timeout from 120s to 180s - #301

Merged
ProtocolWarden merged 1 commit into
mainfrom
oc-watchdog/20260614-1818-c29-service-py-exclusion
Jun 15, 2026
Merged

fix(custodian-sweep): raise per-repo timeout from 120s to 180s#301
ProtocolWarden merged 1 commit into
mainfrom
oc-watchdog/20260614-1818-c29-service-py-exclusion

Conversation

@ProtocolWarden

Copy link
Copy Markdown
Owner

Summary

  • OC custodian-audit takes ~94s under light load but exceeds 120s when the sweep runs parallel jobs
  • The 120s timeout caused the sweep to emit custodian-audit timed out (>120s) for OperationsCenter every cycle, even though the audit reports 0 findings
  • Raising default to 180s eliminates false-positive timeout errors for OC without affecting other repos

Root cause

OC is the largest managed repo; its audit is CPU-bound across many detectors. Under parallel sweep load, scheduling contention pushes it past 120s. The fix in PR #297 (service.py C29 exclusion) reduced audit time but not enough to reliably stay under 120s.

Test plan

  • tests/test_custodian_sweep.py (11/11 pass — imports _DEFAULT_TIMEOUT_SECONDS directly, no hardcoded value)
  • tests/unit/er000_phase0_golden/ (15/15 pass)
  • OC pre-push audit: 0 findings (confirmed clean)

🤖 Generated with Claude Code

@ProtocolWarden

Copy link
Copy Markdown
Owner Author

Needs human attention (reason=rebase_conflict). Left open — not merged (unresolved) and not closed (work preserved).

Auto-rebase onto the base branch hit a real code conflict (beyond the union-merged journal). Manual rebase required.

1 similar comment
@ProtocolWarden

Copy link
Copy Markdown
Owner Author

Needs human attention (reason=rebase_conflict). Left open — not merged (unresolved) and not closed (work preserved).

Auto-rebase onto the base branch hit a real code conflict (beyond the union-merged journal). Manual rebase required.

@ProtocolWarden

ProtocolWarden commented Jun 15, 2026

Copy link
Copy Markdown
Owner Author

Resolved: new push — automated review resumed

Needs human attention (reason=rebase_conflict). Left open — not merged (unresolved) and not closed (work preserved).

Auto-rebase onto the base branch hit a real code conflict (beyond the union-merged journal). Manual rebase required.

OC custodian-audit runs ~94s under light load but consistently exceeds
120s when the sweep is running parallel jobs. The timeout caused the sweep
to emit `custodian-audit timed out (>120s)` for OperationsCenter each
cycle even though the audit itself reports 0 findings. 180s gives the OC
audit a safe margin even under concurrent sweep load.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ProtocolWarden
ProtocolWarden force-pushed the oc-watchdog/20260614-1818-c29-service-py-exclusion branch from d8d3b0f to cce816b Compare June 15, 2026 06:21
@ProtocolWarden
ProtocolWarden merged commit cdf1e40 into main Jun 15, 2026
18 checks passed
@ProtocolWarden
ProtocolWarden deleted the oc-watchdog/20260614-1818-c29-service-py-exclusion branch June 15, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant