Enable MoP 5.4.8 loot-roll SMSG packets for group/LFG loot. - #1240
Open
DigiD702 wants to merge 3 commits into
Open
Enable MoP 5.4.8 loot-roll SMSG packets for group/LFG loot.#1240DigiD702 wants to merge 3 commits into
DigiD702 wants to merge 3 commits into
Conversation
Port bitpacked SMSG_LOOT_START_ROLL / ROLL / ROLL_WON / ALL_PASSED builders and SMSG_LOOT_ROLLS_COMPLETE so Need Before Greed rolls reach the client instead of being dropped as STATUS_UNHANDLED.
Move START_ROLL and ROLLS_COMPLETE bitpacking into the Send* helpers so packet strings sit inline like the other loot-roll writers.
AriDEV3
reviewed
Jul 24, 2026
| data.WriteBit(lootedGuid[0]); | ||
| data.WriteBit(!unk56); | ||
| data.WriteBits(3, 2); | ||
| data.WriteByteSeq(lootedGuid[7]); |
Contributor
There was a problem hiding this comment.
data.FlushBits(); missing before this append.
AriDEV3
reviewed
Jul 24, 2026
| data.WriteBit(byte0x38 != 0); | ||
| data.WriteBit(lootedGuid[6]); | ||
| data.WriteBit(lootedGuid[5]); | ||
| data << uint32(0); |
Contributor
There was a problem hiding this comment.
data.FlushBits(); missing before this append.
AriDEV3
reviewed
Jul 24, 2026
| data.WriteBit(lootedGuid[5]); | ||
| data.WriteBit(lootedGuid[7]); | ||
| data.WriteBit(lootedGuid[0]); | ||
| data.WriteByteSeq(lootedGuid[6]); |
Contributor
There was a problem hiding this comment.
data.FlushBits(); missing before this append.
AriDEV3
reviewed
Jul 24, 2026
AriDEV3
left a comment
AriDEV3
left a comment
Contributor
There was a problem hiding this comment.
missing some bits to be flushed, before appending data.
AriDEV3
reviewed
Jul 24, 2026
| data.WriteBit(targetGuid[4]); | ||
| data.WriteBit(targetGuid[2]); | ||
| data.WriteBit(lootedGuid[1]); | ||
| data.WriteByteSeq(lootedGuid[7]); |
Contributor
There was a problem hiding this comment.
data.FlushBits(); missing before this append.
WriteByteSeq skips zero bytes and would not flush; explicit FlushBits keeps the following appends aligned with the MoP bitpacked layout.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port bitpacked SMSG_LOOT_START_ROLL / ROLL / ROLL_WON / ALL_PASSED builders and SMSG_LOOT_ROLLS_COMPLETE so Need Before Greed rolls reach the client instead of being dropped as STATUS_UNHANDLED.