Fix InfluxDB profile reads never sending credentials #365
Open
jarsarasty wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes authenticated InfluxDB profile reads by sourcing credentials from environment variables (INFLUXDB_USERNAME / INFLUXDB_PASSWORD) instead of an unused, always-empty in-function credential map, aligning simulator-core’s read path with the approach used in other workers.
Changes:
- Add
osimport and read InfluxDB credentials fromINFLUXDB_USERNAME/INFLUXDB_PASSWORD. - Remove the dead
influx_cred_mapstub and always constructConnectionSettingswith the env-provided credentials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reads INFLUXDB_USERNAME/INFLUXDB_PASSWORD from the environment instead of the dead influx_cred_map stub, matching the convention already used by simulator-worker's own profile-write path and by optimizer-worker.
Fixes #364