fix pipe mapper message for diameter#362
Open
AshrafAlmohagryDeltares wants to merge 3 commits into
Open
Conversation
samvanderzwan
requested changes
Jul 16, 2026
| return inner_diameter | ||
|
|
||
| dn_diameter = esdl_asset.get_property("diameter", PIPE_DEFAULTS.diameter) | ||
| if dn_diameter is PIPE_DEFAULTS.diameter: |
Contributor
There was a problem hiding this comment.
This looks weird, I do not know what the type of the diameter property is in ESDL, but it is not a float, but then you compare it to a float.
I do not know the solution, but this does not feel right.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
small fix for the messages shown in the terminal for the diameter. Currently messages shows value None is used if default value is used as diameter. Also, because the message is raised by get_property method, it doesnt indicate correctly if its the inner diameter or diameter which is missing.