Skip to content

174 enable postgres timeseries storage#187

Open
MarkTNO wants to merge 10 commits into
mainfrom
174-enable-postgres-timeseries-storage
Open

174 enable postgres timeseries storage#187
MarkTNO wants to merge 10 commits into
mainfrom
174-enable-postgres-timeseries-storage

Conversation

@MarkTNO

@MarkTNO MarkTNO commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@MarkTNO MarkTNO linked an issue Jul 9, 2026 that may be closed by this pull request
@MarkTNO
MarkTNO requested a review from cwang39403 July 17, 2026 13:06
Comment thread postgres/postgres-init.sql Outdated
-- create roles
CREATE ROLE :JOBS_RW_USER_NAME LOGIN PASSWORD :'JOBS_RW_USER_PASSWORD';
CREATE ROLE :TIMESERIES_RW_USER_NAME LOGIN PASSWORD :'TIMESERIES_RW_USER_PASSWORD';
ALTER ROLE :TIMESERIES_RW_USER_NAME CREATEDB;

@cwang39403 cwang39403 Jul 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, each run creates a new DB in Postgres, and omotes_timeseries is not being used at all.
image

I believe writing optimization runs per schema under the same database (e.g., omotes_timeseries) is a more logical (simpler, more maintainable) design choice in the PostgreSQL case? And within the same schema, there can be different tables per carrier generated from the Mesido optimization run.

Therefore, should it be create schema role instead of create db?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ewoudwerkman Mark and I were discussing this. Do you agree with the comment above? Then some mesido code changes are needed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to use schemas instead of databases, to group things

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread track_memory.sh
@@ -0,0 +1,4 @@
while true; do
date +"%Y-%m-%d %H:%M:%S"
docker stats 79e4e234711e --no-stream --format "{{.Name}} {{.MemUsage}}"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace container id with service name?

Maybe we can limit logs to no more than a certain number of lines (e.g. 1000)?
tail -n 1000 container_mem.log > container_mem.tmp && mv container_mem.tmp container_mem.log

Comment thread scripts/setup.ps1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who is still using PowerShell scripts (Deltares, TPG)? Do we need to keep maintaining them?

If so, the current role and privilege assignments that are defined in postgres/postgres-init.sql are not fully reflected here yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enable postgres timeseries storage

3 participants