fix(chart): honor kube-scheduler image pull secrets

[spencercjh]

What type of PR is this?

/kind bug

What this PR does / why we need it:

The scheduler Pod currently includes global and extender image pull secrets but ignores scheduler.kubeScheduler.image.pullSecrets. This can prevent a private kube-scheduler image from being pulled.

Update the existing hami.scheduler.extender.imagePullSecrets helper to include kube-scheduler pull secrets when its container is enabled, while retaining global and extender secrets.

Which issue(s) this PR fixes:

None.

Special notes for your reviewer:

• Rendered YAML was also parsed to verify Pod-level secret references, private image names, and kube-scheduler container presence. No live private-registry pull was tested.
• AI disclosure: Codex generated the code changes, ran validation, and prepared this PR description.

Does this PR introduce a user-facing change?:

Yes. scheduler.kubeScheduler.image.pullSecrets now contributes to the scheduler Pod's imagePullSecrets when kube-scheduler is enabled.

Summary by CodeRabbit

• Bug Fixes
  • Image pull secrets now account for both the scheduler extender image and the optional kube-scheduler image when enabled.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 87083264-b503-45e8-9501-2bf669d197ed

📥 Commits

Reviewing files that changed from the base of the PR and between 16ef415 and e8d7220.

📒 Files selected for processing (1)

• charts/hami/templates/_helpers.tpl

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.

---

📝 Walkthrough

Walkthrough

The scheduler extender helper now resolves pull secrets from the extender image and, when enabled, the kube-scheduler image.

Changes

Scheduler image pull secret resolution

Layer / File(s)	Summary
Image pull secret resolution charts/hami/templates/_helpers.tpl	The helper builds an images list with the extender image and conditionally adds the kube-scheduler image before resolving pull secrets.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to e8d72

Scheduler pods now include pull secrets configured for an enabled kube-scheduler image alongside existing secrets, allowing private scheduler images to be pulled. No current merge-blocking risk remains.

Poem

A rabbit checks the chart with care
Two scheduler images gather there
Pull secrets follow every name
The helper keeps the path the same
Hop, the template is ready to share

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: ensuring the chart honors kube-scheduler image pull secrets.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag	Coverage Δ
unittests	71.24% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[spencercjh]

/assign @mesutoezdil

[maishivamhoo123]

/lgtm

[FouoF]

/lgtm

[hami-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FouoF, spencercjh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [FouoF]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment