[Port] No energy chem#815
Open
Unlimited-Pii wants to merge 6 commits into
Open
Conversation
Echem rebalance
Contributor
WalkthroughReverte o protótipo ChangesReversão de proto nos mapas para ChemDispenser
Migração de protótipo, receitas e inventário de dispenser de química
Estimated code review effort: 2 (Simple) | ~12 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
Changes: Map
Changes: No C#
and removed
S: Untriaged
size/M
labels
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Resources/Prototypes/_Goobstation/Entities/Structures/Machines/lathe.yml (1)
215-228: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
MedicalBoardsestá amplo demais para o ScienceTechFabO pack
MedicalBoardstambém liberaStasisBedMachineCircuitboard,CryoPodMachineCircuitboard,BiomassReclaimerMachineCircuitboardeStasisOperatingTableCircuitboard. Se a intenção é deixar só oEnergyChemDispenserMachineCircuitboardpesquisável por Science, isso precisa virar um pack separado.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Prototypes/_Goobstation/Entities/Structures/Machines/lathe.yml` around lines 215 - 228, The ScienceTechFab dynamicPacks entry currently uses MedicalBoards, which unlocks more than just the intended EnergyChemDispenserMachineCircuitboard. Split the unrelated boards into a separate pack and update the dynamicPacks list in the ScienceTechFab prototype so only the science-appropriate board remains exposed; use the MedicalBoards pack name and the ScienceTechFab prototype block to locate the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/Prototypes/Research/civilianservices.yml`:
- Around line 333-349: `ServiceBluespaceChemistry` is unlocking a missing recipe
prototype, `ServiceEnergyChemMachineCircuitboard`, which breaks prototype
validation. Update the `recipeUnlocks` entry in `civilianservices.yml` to point
to the existing `EnergyChemDispenserMachineCircuitboard`, or remove the unlock
from `ServiceBluespaceChemistry` if it is not needed, so the technology
references only valid prototypes.
---
Outside diff comments:
In `@Resources/Prototypes/_Goobstation/Entities/Structures/Machines/lathe.yml`:
- Around line 215-228: The ScienceTechFab dynamicPacks entry currently uses
MedicalBoards, which unlocks more than just the intended
EnergyChemDispenserMachineCircuitboard. Split the unrelated boards into a
separate pack and update the dynamicPacks list in the ScienceTechFab prototype
so only the science-appropriate board remains exposed; use the MedicalBoards
pack name and the ScienceTechFab prototype block to locate the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 4571cad0-eb48-4bb7-9dc0-2ab58022ddf8
📒 Files selected for processing (26)
Resources/Maps/.oasis.ymlResources/Maps/_Goobstation/amber.ymlResources/Maps/_Goobstation/atlas.ymlResources/Maps/_Goobstation/bagel.ymlResources/Maps/_Goobstation/barratry.ymlResources/Maps/_Goobstation/box.ymlResources/Maps/_Goobstation/chloris.ymlResources/Maps/_Goobstation/cluster.ymlResources/Maps/_Goobstation/cog.ymlResources/Maps/_Goobstation/delta.ymlResources/Maps/_Goobstation/fland.ymlResources/Maps/_Goobstation/kettle.ymlResources/Maps/_Goobstation/leonid.ymlResources/Maps/_Goobstation/marathon.ymlResources/Maps/_Goobstation/meta.ymlResources/Maps/_Goobstation/oasis.ymlResources/Maps/_Goobstation/omega.ymlResources/Maps/_Goobstation/origin.ymlResources/Maps/_Goobstation/saltern.ymlResources/Maps/_Goobstation/serpentcrest.ymlResources/Prototypes/Catalog/VendingMachines/Inventories/chemvend.ymlResources/Prototypes/Recipes/Lathes/Packs/medical.ymlResources/Prototypes/Research/civilianservices.ymlResources/Prototypes/_Goobstation/Entities/Structures/Machines/lathe.ymlResources/Prototypes/_Goobstation/Recipes/Lathes/medical.ymlResources/migration.yml
Contributor
|
Contributor
|
Contributor
Author
|
Our hero battling EVIL med powercreep |
Collaborator
|
changelog mente dizendo que é pesquisavel @Unlimited-Pii |
Contributor
Author
Oops, deveria ser. Vou arrumar chegando em casa, obrigado! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sobre a PR
Remove dispensores químicos de energia roundstart e faz deles pesquisáveis pela Sci.
Por quê? / Balanceamento
Consultar discussões em Discord.
Detalhes Técnicos
Port do Goob, consultar PR original.
Anexos
Requerimentos
Changelog
🆑