[ATT] Itens novos e ajustes nos Revolucionários#764
Open
Struater wants to merge 30 commits into
Open
Conversation
Contributor
|
RSI Diff Bot; head commit 16bfbd1 merging into 41d4311 Resources/Textures/_Trauma/Interface/Misc/job_icons.rsi
Resources/Textures/_Trauma/Objects/Revs/components.rsi
Resources/Textures/_Trauma/Objects/Revs/kunai.rsi
Resources/Textures/_Trauma/Objects/Revs/maul.rsi
Resources/Textures/_Trauma/Objects/Revs/maul_inhands_64x.rsi
Resources/Textures/_Trauma/Objects/Weapons/Guns/LightMachineGuns/proletariat.rsi
Resources/Textures/_Trauma/Objects/Weapons/Guns/LightMachineGuns/proletariat_inhands_x64.rsi
Resources/Textures/_Trauma/Structures/Machines/hiddenmedifab.rsi
|
Contributor
WalkthroughAdiciona novas armas para a facção revolucionária: armas corpo a corpo forjadas (RevMaul, RevKunai), LMG Proletariat com magazine pesada de torreta, medifab oculta construível (RevMedFab) e correção do ícone de status RevolutionEnemy. Inclui entidades YAML, grafos de construção, receitas de lathe, blueprints, spawners de drop pod e assets RSI. ChangesExpansão de conteúdo revolucionário
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Resources/Prototypes/_Trauma/Entities/Objects/Weapons/Melee/revmelee.yml (1)
205-220:⚠️ Potential issue | 🟠 Major | ⚡ Quick winA capacidade química da
RevKnifeficou inconsistente (3u de volume vs 5u de transferência).Em Line 208,
maxVolcontinua3, mas em Line 210/217/220 a transferência foi aumentada para5. Isso impede o item de cumprir o ajuste esperado de 5u e pode gerar comportamento truncado em uso real.💡 Sugestão de ajuste
- type: SolutionContainerManager solutions: melee: - maxVol: 3 + maxVol: 5🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Prototypes/_Trauma/Entities/Objects/Weapons/Melee/revmelee.yml` around lines 205 - 220, The RevKnife's chemical injection system has an inconsistency where the SolutionContainerManager specifies maxVol of 3 units, but the MeleeChemicalInjector, SolutionInjectOnEmbed, and SolutionTransfer components all specify transferAmount or maxTransferAmount of 5 units. This prevents the item from functioning as intended since the container capacity is smaller than the transfer amounts. Increase the maxVol value in SolutionContainerManager from 3 to 5 to match the transfer amounts specified in the other components.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/Prototypes/_Trauma/Entities/Objects/Blueprints/mold.yml`:
- Around line 30-36: The reference to the `ForgeMold` tag in the mold.yml file
is causing the content linter to fail because the tag prototype does not exist
in the loaded tags definition. Either add the `ForgeMold` tag definition to the
tags definition file (typically in Resources/Prototypes/_Trauma/Tags or
similar), or replace the `ForgeMold` reference in the Tag component of the
mold.yml entity with a valid, existing tag that is already defined in the tags
file. Ensure the chosen tag accurately represents the purpose of this mold
object.
In
`@Resources/Prototypes/_Trauma/Entities/Objects/Weapons/Guns/Ammunition/Magazines/turret.yml`:
- Line 53: The description field contains offensive language ("assholes") that
will be displayed to players, which violates content quality and localization
standards. Replace the offensive term with neutral, professional wording that
maintains the intended meaning of the description without using derogatory
language. Ensure the revised description remains factually accurate while being
appropriate for all audiences.
In
`@Resources/Prototypes/_Trauma/Entities/Objects/Weapons/Guns/LMGs/Proletariat.yml`:
- Around line 104-114: The WeaponLightMachineGunProletariatEmpty entity has an
empty ContainerFill component, but it still inherits the gun_chamber definition
with its startingItem from the parent WeaponLightMachineGunProletariat entity,
meaning the Empty variant will not actually be empty at runtime. Add an
ItemSlots component to the WeaponLightMachineGunProletariatEmpty entity that
explicitly overrides the gun_chamber container configuration to remove or clear
the startingItem, ensuring the inherited chamber configuration is properly
nullified so the weapon truly starts empty.
- Around line 57-67: The whitelist tags in the Proletariat.yml configuration are
too broad. The whitelist section at line 59 (for the magazine slot) currently
accepts any MagazineTurret tag, and the whitelist section at line 67 (for the
gun_chamber) accepts any CartridgeTurret tag. This contradicts the weapon's
intended .22 short ammunition specification. Replace the generic MagazineTurret
and CartridgeTurret tags with specific .22 short variant tags that restrict
ammunition to only the intended caliber for this LMG.
In `@Resources/Prototypes/_Trauma/Recipes/Construction/Graphs/rev_buildings.yml`:
- Around line 184-185: Remove the empty `icon:` field on line 184 in the
`HudMedical` stage. The `icon:` key has no value definition (no sprite or
state), and since it's optional, it should be deleted entirely to maintain clean
code practices and consistency with other stages in the file. Delete the entire
line containing only `icon:` with its indentation.
---
Outside diff comments:
In `@Resources/Prototypes/_Trauma/Entities/Objects/Weapons/Melee/revmelee.yml`:
- Around line 205-220: The RevKnife's chemical injection system has an
inconsistency where the SolutionContainerManager specifies maxVol of 3 units,
but the MeleeChemicalInjector, SolutionInjectOnEmbed, and SolutionTransfer
components all specify transferAmount or maxTransferAmount of 5 units. This
prevents the item from functioning as intended since the container capacity is
smaller than the transfer amounts. Increase the maxVol value in
SolutionContainerManager from 3 to 5 to match the transfer amounts specified in
the other components.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: ac4ff7fe-1a56-4ef7-9814-3d01eee72812
⛔ Files ignored due to path filters (23)
Resources/Audio/_Trauma/Weapons/Melee/breaching_hammer/club.oggis excluded by!**/*.oggResources/Textures/_Trauma/Interface/Misc/job_icons.rsi/RevolutionEnemy.pngis excluded by!**/*.pngResources/Textures/_Trauma/Objects/Revs/components.rsi/kunai.pngis excluded by!**/*.pngResources/Textures/_Trauma/Objects/Revs/components.rsi/maul.pngis excluded by!**/*.pngResources/Textures/_Trauma/Objects/Revs/kunai.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Trauma/Objects/Revs/kunai.rsi/icon1.pngis excluded by!**/*.pngResources/Textures/_Trauma/Objects/Revs/kunai.rsi/inhand-left-fill-1.pngis excluded by!**/*.pngResources/Textures/_Trauma/Objects/Revs/kunai.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/_Trauma/Objects/Revs/kunai.rsi/inhand-right-fill-1.pngis excluded by!**/*.pngResources/Textures/_Trauma/Objects/Revs/kunai.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/_Trauma/Objects/Revs/maul.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Trauma/Objects/Revs/maul_inhands_64x.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/_Trauma/Objects/Revs/maul_inhands_64x.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/_Trauma/Objects/Revs/maul_inhands_64x.rsi/wielded-inhand-left.pngis excluded by!**/*.pngResources/Textures/_Trauma/Objects/Revs/maul_inhands_64x.rsi/wielded-inhand-right.pngis excluded by!**/*.pngResources/Textures/_Trauma/Objects/Weapons/Guns/LightMachineGuns/proletariat.rsi/base.pngis excluded by!**/*.pngResources/Textures/_Trauma/Objects/Weapons/Guns/LightMachineGuns/proletariat.rsi/bolt-open.pngis excluded by!**/*.pngResources/Textures/_Trauma/Objects/Weapons/Guns/LightMachineGuns/proletariat.rsi/mag-0.pngis excluded by!**/*.pngResources/Textures/_Trauma/Objects/Weapons/Guns/LightMachineGuns/proletariat_inhands_x64.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/_Trauma/Objects/Weapons/Guns/LightMachineGuns/proletariat_inhands_x64.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/_Trauma/Objects/Weapons/Guns/LightMachineGuns/proletariat_inhands_x64.rsi/wielded-inhand-left.pngis excluded by!**/*.pngResources/Textures/_Trauma/Objects/Weapons/Guns/LightMachineGuns/proletariat_inhands_x64.rsi/wielded-inhand-right.pngis excluded by!**/*.pngResources/Textures/_Trauma/Structures/Machines/hiddenmedifab.rsi/icon.pngis excluded by!**/*.png
📒 Files selected for processing (28)
Content.Goobstation.Shared/Revolutionary/RevolutionEnemyComponent.csResources/Prototypes/_Trauma/Entities/Objects/Blueprints/mold.ymlResources/Prototypes/_Trauma/Entities/Objects/Revs/spawners.ymlResources/Prototypes/_Trauma/Entities/Objects/Revs/unfinished.ymlResources/Prototypes/_Trauma/Entities/Objects/Weapons/Guns/Ammunition/Magazines/turret.ymlResources/Prototypes/_Trauma/Entities/Objects/Weapons/Guns/LMGs/Proletariat.ymlResources/Prototypes/_Trauma/Entities/Objects/Weapons/Melee/revmelee.ymlResources/Prototypes/_Trauma/Entities/Structures/Machines/lathe.ymlResources/Prototypes/_Trauma/Recipes/Construction/Graphs/rev_buildings.ymlResources/Prototypes/_Trauma/Recipes/Construction/revbuildings.ymlResources/Prototypes/_Trauma/Recipes/Crafting/Graphs/rev_weapons.ymlResources/Prototypes/_Trauma/Recipes/Crafting/rev_weapons.ymlResources/Prototypes/_Trauma/Recipes/Lathes/Packs/revrecipepacks.ymlResources/Prototypes/_Trauma/Recipes/Lathes/medical.ymlResources/Prototypes/_Trauma/Recipes/Lathes/rev_ammo.ymlResources/Prototypes/_Trauma/Recipes/Lathes/rev_datachips.ymlResources/Prototypes/_Trauma/Recipes/Lathes/rev_parts.ymlResources/Prototypes/_Trauma/Recipes/Lathes/rev_weapons.ymlResources/Prototypes/_Trauma/StatusIcon/faction.ymlResources/Prototypes/_Trauma/tags.ymlResources/Textures/_Trauma/Interface/Misc/job_icons.rsi/meta.jsonResources/Textures/_Trauma/Objects/Revs/components.rsi/meta.jsonResources/Textures/_Trauma/Objects/Revs/kunai.rsi/meta.jsonResources/Textures/_Trauma/Objects/Revs/maul.rsi/meta.jsonResources/Textures/_Trauma/Objects/Revs/maul_inhands_64x.rsi/meta.jsonResources/Textures/_Trauma/Objects/Weapons/Guns/LightMachineGuns/proletariat.rsi/meta.jsonResources/Textures/_Trauma/Objects/Weapons/Guns/LightMachineGuns/proletariat_inhands_x64.rsi/meta.jsonResources/Textures/_Trauma/Structures/Machines/hiddenmedifab.rsi/meta.json
Contributor
|
This pull request has been automatically marked as stale because it has not had You can always ask for help on our development discord. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
Contributor
Author
|
No! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sobre a PR
Adição de conteudo e ajustes
Porta a PR Trauma-Station/Trauma-Station#2746 e os ajustes da pr Trauma-Station/Trauma-Station#2497
Por quê? / Balanceamento
Ficar em dia com o Trauma
Detalhes Técnicos
YAML no geral
Anexos
Requerimentos
Changelog
🆑 Struater
add: Revs agora podem criar um fabricador médico de subsolo!
add: Adicionado o Proletariat, uma metralhadora leve (LMG) para os revs que usa munição calibre .22 Short!
add: Adicionado o Maul, uma poderosa ferramenta antiarmadura para os revs.
add: Adicionado o Kunai, uma pá para os revs. Sim, uma pá. Kunais são pás.
tweak: Faca Forjada agora comporta 5u de químicos em vez de 3u.
tweak: Espada Forjada agora cabe em bolsas duffel.
tweak: Garfo Forjado agora cabe nas mochilas dos revs.
tweak: Inimigos da Revolução agora possui seu próprio ícone de caveira vermelha, em vez de reutilizar literalmente o ícone dos revs.
tweak: Ball Bearings agoram podem ser feitas na Forja dos Rev