Repository navigation
docs: bring the docs in line with the code and ship the font licences - #84
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
.metasidecar said only the launcher's self-update consumes it, which contradicted the trust-boundary paragraph below it. The code (src/download.rs, the app install path) verifies app sidecars whenever they are published and pins them, so the earlier sentence was the wrong one.git grep save_installed_metadata v0.9.2finds nothing, v0.10.0 has it).<cache>/repo-icons/<repo>/icon.png(repo_icon_dirinsrc/persistence.rs), not<data>.colony-bindownload is about 30 MB (v0.10.3colony-linuxis 30,299,936 bytes), not 40.GITHUB_ACCOUNTinsrc/github/http.rs,/orgs/{GITHUB_ACCOUNT}/reposinsrc/github/catalog.rs).HTTP_CACHEinsrc/github/http.rsand docs/architecture.md said 304s are free outright. Comment and doc only, no behaviour change.MotherSphere/Colony; the repository isProject-Colony/Colony.OFL.txtnext to each:LICENSE.txtfonts section (the font's own name table only says "Copyright (c) Font Awesome"), followed by the standard OFL 1.1 text.Checks run locally (isolated XDG dirs)
cargo fmt --all -- --check: passcargo clippy --all-targets -- -D warnings: pass on the default toolchain and on rustc 1.99.0cargo test: 150 passed, 0 failedcargo check --locked --all-targets: passNot verified