This repository was archived by the owner on Feb 4, 2021. It is now read-only.
画像の存在しない戦歴にはog:imageを適用#106
Open
mirror-kt wants to merge 2 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
Author
|
debugged. |
gedorinku
reviewed
Aug 9, 2019
Member
There was a problem hiding this comment.
UpdateAchievementした直後にユーザーが戦歴の画像を更新したら、og:imageかユーザーが指定した画像か、どちらが最終的に残るか不定になっちゃいそうですね。
og:imageのURLは別のカラムに保存するのが良いかなと思います。
DBのスキーマ達(Active Record風):
https://github.com/ProgrammingLab/prolab-accounts/tree/master/db
これを変更した後に、
$ scripts/setup-db
$ go generate ./...
するとDBのスキーマが変更できます。
Member
Author
|
|
Member
|
configの |
Member
Author
|
|
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#104 に対するPull Request