chore: land the deferred cleanups from the 2.4.0 review cycle - #33
Merged
Conversation
Delete the orphaned extractOps, share displayOp between resolver and generator, consolidate five record guards into spec-utils, tighten the servers-classification warnings (apex host, non-https labeling, url-less entries), close proposeName's bare-verb hole, cover the vnd content-type restoration branch and unknown component categories in tests, fix the path-item conflict message wording, and polish the sync workflow summaries. Generated output is byte-identical.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ); | ||
|
|
||
| assert.strictEqual(warnings.length, 1); | ||
| assert.ok(/sandboxapi\.deere\.com/.test(warnings[0]), 'names the offending url'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All FOLLOW-UP minors triaged by the 2.4.0 branch reviews, in one pass: delete the orphaned extractOps, share displayOp between resolver and generator, consolidate five identical record guards into spec-utils (a sixth in embed-contracts.ts is noted for a future pass), tighten the servers-classification warnings (apex deere.com host counts as platform-family, non-https deere urls no longer mislabeled, url-less entries warn instead of vanishing silently, mixed-block behavior locked by test), close proposeName's bare-verb hole, cover the vnd content-type restoration branch and unknown component categories in tests, fix the path-item conflict message wording, repoint a stale test comment, and polish the sync workflow summaries.
Generated output is byte-identical (gate verified), the servers trust boundary is untouched byte-for-byte (reviewer-traced), and no release results from this merge. 443 tests, lint, both typechecks, build, actionlint: all green.