Skip to content

fix: add .catch() to promise chains - #3273

Closed
saurabhhhcodes wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
saurabhhhcodes:fix/devtrack-p-9736
Closed

fix: add .catch() to promise chains#3273
saurabhhhcodes wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
saurabhhhcodes:fix/devtrack-p-9736

Conversation

@saurabhhhcodes

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix type:feature GSSoC type bonus: new feature labels Jul 29, 2026
@github-actions

Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@github-actions github-actions Bot added the type:performance GSSoC type bonus: performance (+15 pts) label Jul 29, 2026
@Priyanshu-byte-coder

Copy link
Copy Markdown
Owner

Closing — the change is incorrect. It moves the radix argument into the wrong function:

- parseInt(req.nextUrl.searchParams.get("days") ?? "90", 10)
+ parseInt(req.nextUrl.searchParams.get("days", 10) ?? "90", 10)

URLSearchParams.get() takes exactly one argument, so this breaks the build (TS2554: Expected 1 arguments, but got 2). And it wasn't needed — parseInt already had its radix 10 as the second argument, which is the correct place for it.

Note the title doesn't match the diff either. Please run pnpm type-check locally before pushing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix type:feature GSSoC type bonus: new feature type:performance GSSoC type bonus: performance (+15 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants