Skip to content

fix: add HTTP status check before JSON parse - #3272

Closed
saurabhhhcodes wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
saurabhhhcodes:fix/devtrack-9713
Closed

fix: add HTTP status check before JSON parse#3272
saurabhhhcodes wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
saurabhhhcodes:fix/devtrack-9713

Conversation

@saurabhhhcodes

Copy link
Copy Markdown
Contributor

This fix improves error handling to prevent silent failures.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix type:feature GSSoC type bonus: new feature type:testing GSSoC type bonus: tests (+10 pts) and removed gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix type:feature GSSoC type bonus: new feature labels Jul 29, 2026
@github-actions

Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@Priyanshu-byte-coder

Copy link
Copy Markdown
Owner

Closing — this deletes 1,055 lines across three test files (data-export, goals-sync, user-export) while the title claims it adds an HTTP status check. It leaves the files truncated, so Type check fails with TS1003/TS1005. This would wipe out a large part of the test suite.

Please review your own diff before opening a PR, and confirm pnpm type-check && pnpm test pass locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:testing GSSoC type bonus: tests (+10 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants