Skip to content

feat(dashboard): subject filter on findings and events #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xre217 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(dashboard): subject filter on findings and events #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions TODO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ Rough sketch:

## Medium priority

### Dashboard subject filter
Data is already captured and tagged per-user in findings/events (field: `subject`). The dashboard (`prismor/runtime/server.py` `/api/findings`, `/api/events`) and `prismor/runtime/dashboard.html` don't yet expose a subject filter or column. Add:
### ~~Dashboard subject filter~~ — DONE
Data is already captured and tagged per-user in findings/events (field: `subject`). Exposed via:
- `?subject=user:alice` query param on `/api/findings` / `/api/events`
- A "User" column in the findings table
- A user dropdown filter in `dashboard.html`
Expand Down
46 changes: 33 additions & 13 deletions prismor/runtime/dashboard.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1552,6 +1552,8 @@ <h2>Findings &amp; Events</h2><div class="rule"></div>
<div class="bar">
<label>Agent</label>
<select id="fAgent" class="fsel"><option value="">All</option></select>
<label>User</label>
<select id="fSubject" class="fsel"><option value="">All</option></select>
<label>Severity</label>
<select id="fSev" class="fsel">
<option value="">All</option>
Expand All @@ -1576,7 +1578,7 @@ <h2>Findings &amp; Events</h2><div class="rule"></div>
<div style="overflow-x:auto">
<table>
<thead><tr>
<th>Finding</th><th>Agent</th><th>Category</th><th>Severity</th><th>When</th><th style="width:16px"></th>
<th>Finding</th><th>Agent</th><th>User</th><th>Category</th><th>Severity</th><th>When</th><th style="width:16px"></th>
</tr></thead>
<tbody id="findBody"></tbody>
</table>
Expand All @@ -1595,6 +1597,8 @@ <h2>Findings &amp; Events</h2><div class="rule"></div>
<div class="bar-sep"></div>
<label>Agent</label>
<select id="evtAgent" class="fsel"><option value="">All</option></select>
<label>User</label>
<select id="evtSubject" class="fsel"><option value="">All</option></select>
<div class="bar-right">
<span id="evtCount" class="result-count"></span>
<label>Per page</label>
Expand Down Expand Up @@ -3420,17 +3424,21 @@ <h3>Prismor Enterprise</h3>
});

// ── Findings ──────────────────────────────────────────────────────────────
const findState={page:1,limit:25,agent:'',severity:'',category:'',q:'',total:0,pages:1};
const findState={page:1,limit:25,agent:'',severity:'',category:'',q:'',subject:'',total:0,pages:1};
async function loadFindings(){
const {page,limit,agent,severity,category,q}=findState;
const params=new URLSearchParams({page,limit,agent,severity,category,q});
const {page,limit,agent,severity,category,q,subject}=findState;
const params=new URLSearchParams({page,limit,agent,severity,category,q,subject});
try{
const data=await apiFetch('/api/findings?'+params);
findState.page=data.page; findState.pages=data.pages; findState.total=data.total;
if(data.agents){
const sel=document.getElementById('fAgent'); const cur=sel.value;
sel.innerHTML='<option value="">All</option>'+data.agents.map(a=>'<option value="'+a+'"'+(a===cur?' selected':'')+'>'+a+'</option>').join('');
}
if(data.subjects){
const sel=document.getElementById('fSubject'); const cur=findState.subject || sel.value;
sel.innerHTML='<option value="">All</option>'+data.subjects.map(s=>'<option value="'+safeAttr(s)+'"'+(s===cur?' selected':'')+'>'+safe(s)+'</option>').join('');
}
if(data.categories){
const sel=document.getElementById('fCat'); const cur=sel.value;
sel.innerHTML='<option value="">All</option>'+data.categories.map(c=>'<option value="'+c+'"'+(c===cur?' selected':'')+'>'+( CAT_LABELS[c]||c)+'</option>').join('');
Expand All @@ -3442,26 +3450,30 @@ <h3>Prismor Enterprise</h3>
}
function renderFindings(rows){
const tbody=document.getElementById('findBody');
if(!rows.length){tbody.innerHTML='<tr><td colspan="6" class="empty">No findings match the current filters</td></tr>';return;}
if(!rows.length){tbody.innerHTML='<tr><td colspan="7" class="empty">No findings match the current filters</td></tr>';return;}
tbody.innerHTML=rows.map((f,i)=>{
const eid='fev-'+i;
const trig=f.trigger||{};
const triggerBlock=trig.detail
?'<div style="margin-top:8px"><span class="trigger-kind">'+safe(trig.kind||'event')+'</span><div class="trigger-detail">'+safe(trig.detail)+'</div></div>'
:'';
const userLabel=f.subject||'—';
return '<tr class="finding-row" onclick="toggleEvidence(\''+eid+'\')">'+
'<td>'+safe(f.title)+'</td>'+
'<td><span class="agent-pill">'+safe(f.agent)+'</span></td>'+
'<td style="color:var(--gray-500)" title="'+safeAttr(f.subject||'')+'">'+safe(userLabel)+'</td>'+
'<td style="color:var(--gray-500)">'+safe(CAT_LABELS[f.category]||f.category)+'</td>'+
'<td><span class="sev-badge '+sevClass(f.severity)+'">'+safe(f.severity)+'</span></td>'+
'<td>'+tsCell(f.ts,f.tsAbs)+'</td>'+
'<td class="expand-arrow">▸</td>'+
'</tr>'+
'<tr id="'+eid+'" class="finding-ev-row">'+
'<td class="finding-ev-cell" colspan="6">'+
'<td class="finding-ev-cell" colspan="7">'+
'<div>'+safe(f.evidence||'No evidence recorded.')+'</div>'+
triggerBlock+
'<div style="margin-top:8px;font-size:10px;color:var(--gray-400)">session: <span title="'+safeAttr(f.sessionId)+'">'+safe(shortId(f.sessionId,32))+'</span></div>'+
'<div style="margin-top:8px;font-size:10px;color:var(--gray-400)">session: <span title="'+safeAttr(f.sessionId)+'">'+safe(shortId(f.sessionId,32))+'</span>'+
(f.subject?' &middot; user: '+safe(f.subject):'')+
'</div>'+
'</td>'+
'</tr>';
}).join('');
Expand All @@ -3472,8 +3484,9 @@ <h3>Prismor Enterprise</h3>
const prev=row.previousElementSibling;
if(prev){const arrow=prev.querySelector('.expand-arrow');if(arrow)arrow.textContent=row.classList.contains('open')?'▾':'▸';}
}
['fAgent','fSev','fCat'].forEach(id=>document.getElementById(id).addEventListener('change',e=>{
findState[id==='fAgent'?'agent':id==='fSev'?'severity':'category']=e.target.value;
['fAgent','fSev','fCat','fSubject'].forEach(id=>document.getElementById(id).addEventListener('change',e=>{
const map={fAgent:'agent',fSev:'severity',fCat:'category',fSubject:'subject'};
findState[map[id]]=e.target.value;
findState.page=1; loadFindings();
}));
let _findSearchTimer;
Expand All @@ -3486,12 +3499,12 @@ <h3>Prismor Enterprise</h3>
});

// ── Events ────────────────────────────────────────────────────────────────
const evtState={page:1,limit:30,verdict:'',agent:'',total:0,pages:1};
const evtState={page:1,limit:30,verdict:'',agent:'',subject:'',total:0,pages:1};
let _eventsAbort = null;
let _eventsReqId = 0;
async function loadEvents(){
const {page,limit,verdict,agent}=evtState;
const params=new URLSearchParams({page,limit,verdict,agent});
const {page,limit,verdict,agent,subject}=evtState;
const params=new URLSearchParams({page,limit,verdict,agent,subject});
const reqId = ++_eventsReqId;
if (_eventsAbort) _eventsAbort.abort();
const controller = new AbortController();
Expand All @@ -3506,6 +3519,10 @@ <h3>Prismor Enterprise</h3>
const sel=document.getElementById('evtAgent'); const cur=sel.value;
sel.innerHTML='<option value="">All</option>'+data.agents.map(a=>'<option value="'+a+'"'+(a===cur?' selected':'')+'>'+a+'</option>').join('');
}
if(data.subjects){
const sel=document.getElementById('evtSubject'); const cur=evtState.subject || sel.value;
sel.innerHTML='<option value="">All</option>'+data.subjects.map(s=>'<option value="'+safeAttr(s)+'"'+(s===cur?' selected':'')+'>'+safe(s)+'</option>').join('');
}
renderEvents(data.items);
buildPager('evtPager',evtState,loadEvents);
document.getElementById('evtCount').textContent=fmtNum(data.total)+' events';
Expand All @@ -3530,12 +3547,14 @@ <h3>Prismor Enterprise</h3>
const encVerdict = encodeURIComponent(ev.verdict || 'allowed');
const encSeverity = encodeURIComponent(ev.severity || 'low');
const encPolicy = encodeURIComponent(JSON.stringify(ev.policy || {}));
const userMeta = ev.subject ? ' &middot; <span title="end-user subject">'+safe(ev.subject)+'</span>' : '';
return '<div class="event-row" onclick="onEventClick(\''+safeJsArg(sid)+'\',\''+safeJsArg(ws)+'\',\''+safeJsArg(encTag)+'\',\''+safeJsArg(encType)+'\',\''+safeJsArg(encAction)+'\',\''+safeJsArg(encVerdict)+'\',\''+safeJsArg(encSeverity)+'\',\''+safeJsArg(encPolicy)+'\')" title="Open session controls">'+
'<span class="event-dot '+(ev.verdict||'allowed')+'"></span>'+
'<div style="flex:1;min-width:0">'+
'<div class="event-meta">'+
(ev.tsAbs?'<span class="ts-hover" title="'+safeAttr(ev.tsAbs)+'">'+safe(ev.ts)+'</span>':safe(ev.ts))+
' &middot; <strong style="color:var(--gray-600)">'+safe(ev.agent)+'</strong>'+
userMeta+
(sid ? ' &middot; <span class="event-sess-id" title="'+safeAttr(sid)+'">'+safe(shortId(sid,18))+'</span>' : '')+
'</div>'+
'<div class="event-action">'+toolTag+safe(ev.action)+'</div>'+
Expand Down Expand Up @@ -3571,6 +3590,7 @@ <h3>Prismor Enterprise</h3>
});
});
document.getElementById('evtAgent').addEventListener('change',e=>{evtState.agent=e.target.value;evtState.page=1;loadEvents();});
document.getElementById('evtSubject').addEventListener('change',e=>{evtState.subject=e.target.value;evtState.page=1;loadEvents();});
document.getElementById('evtLimit').addEventListener('change',e=>{evtState.limit=parseInt(e.target.value,10);evtState.page=1;loadEvents();});

// ── Stats ─────────────────────────────────────────────────────────────────
Expand Down Expand Up @@ -4344,7 +4364,7 @@ <h3>Prismor Enterprise</h3>
loadSessionControl();
loadPolicy();
loadAgents();
if (findState.page===1 && !findState.agent && !findState.severity && !findState.category && !findState.q) loadFindings();
if (findState.page===1 && !findState.agent && !findState.severity && !findState.category && !findState.q && !findState.subject) loadFindings();
if (evtState.page===1 && !evtState.verdict && !evtState.agent) loadEvents();
}, 30000);
</script>
Expand Down
6 changes: 4 additions & 2 deletions prismor/runtime/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
GET /health → {"status": "ok", "ts": "<iso>"}
GET /api/stats → aggregate stats for charts/KPIs
GET /api/sessions → paginated sessions (?page&limit&sort&dir)
GET /api/findings → paginated findings (?page&limit&agent&severity&category&q)
GET /api/events → paginated events (?page&limit&verdict&agent)
GET /api/findings → paginated findings (?page&limit&agent&severity&category&q&subject)
GET /api/events → paginated events (?page&limit&verdict&agent&subject)
GET /api/supply-chain → supply chain enforcement stats
GET /api/workspaces → registered workspaces + enrollment status
GET /api/policy → all policy layers for a workspace (?workspace=…)
Expand Down Expand Up @@ -215,6 +215,7 @@ def qint(key: str, default: int = 1) -> int:
severity=qstr("severity"),
category=qstr("category"),
search=qstr("q"),
subject=qstr("subject"),
)
except Exception as exc:
self._send_json({"error": str(exc)}, status=500)
Expand All @@ -229,6 +230,7 @@ def qint(key: str, default: int = 1) -> int:
limit=qint("limit", 30),
verdict=qstr("verdict"),
agent=qstr("agent"),
subject=qstr("subject"),
)
except Exception as exc:
self._send_json({"error": str(exc)}, status=500)
Expand Down
Loading