fix(registry): accept http surface + client-side blocking - #175
Merged
Conversation
registry.yaml ships vercel-ai and eval-server with surface: http and blocking: client-side, but SURFACES/BLOCKING enums and the JSON schema still only allowed the older values. scripts/verify_registry.sh failed with AssertionError on vercel-ai. - Add http + client-side to registry.py and registry.schema.json - Document http surface in the integration matrix legend - Run verify_registry.sh in security-regression CI (TODO.md item)
2 tasks
Contributor
Author
|
Following up — opened a second PR for the dashboard subject filter from TODO.md: #176 ( Happy to keep going on MCP proxy or anything else on the list if useful. |
3 tasks
Contributor
|
thanks for mentioning this @xre217 , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/verify_registry.shcurrently fails on main:registry.yamlalready ships vercel-ai and eval-server with:surface: httpblocking: client-side(eval-server)…but the Python enums and JSON schema still only allow the older values, so the fallback validator (and jsonschema, if installed) rejects a valid registry.
Changes
httptoSURFACESandclient-sidetoBLOCKINGinregistry.pyregistry.schema.jsonhttp(eval-server sidecar) in the integration matrix legendbash scripts/verify_registry.shintosecurity-regression.yml(from TODO.md) so this can't regressTest plan
bash scripts/verify_registry.sh→ OK (22 integrations)Came via your comment on the Agent Gate launch gist — happy to help more on MCP proxy / dashboard subject filter if useful.